fix(templates): loading bootstrap files from static, discarding unused files from CDN #276 #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request updates the Bootstrap base template to load CSS and JavaScript files from local static files instead of a CDN. It also removes unused files and updates the documentation to reflect these changes. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Grosskopf - I've reviewed your changes - here's some feedback:
Overall Comments:
- Avoid committing large generated static files like bootstrap.css and bundle.bootstrap.js; generate them via the build process instead.
- The empty private/js/bootstrap.js webpack entry seems redundant or confusing given the presence of the generated bundle.bootstrap.js.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Grosskopf
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #277 +/- ##
=======================================
Coverage 88.68% 88.68%
=======================================
Files 124 124
Lines 3366 3366
Branches 283 283
=======================================
Hits 2985 2985
Misses 264 264
Partials 117 117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…lates and unused card-group, django-cms#276
|
after a lot of confusion about webpack I have decided that this is the best I can do, I have added copy-webpack-plugin as a npm dependency to allow gulp to copy the js file from one folder to another, this does not minimize the js file but I'm not good enough with webpack to figure out how to get this to work with minimization :) |
fsbraun
reviewed
May 12, 2025
| @@ -1,7 +1,8 @@ | |||
| const argv = require('minimist')(process.argv.slice(2)); | |||
| const plugins = []; | |||
| const webpack = require('webpack'); | |||
| const path = require('path'); | |||
| const path = require('path');1 | |||
There was a problem hiding this comment.
Suggested change
| const path = require('path');1 | |
| const path = require('path'); |
I assume the 1 is a typo here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @fsbraun if you want, this PR would address the problems mentioned at #276
I have
Summary by Sourcery
Load Bootstrap assets from local static files instead of CDN and remove unused assets.
Enhancements:
card-group.jscomponent file.Build:
Documentation: