Merge remote-tracking branch 'upstream/master' into newCTFE

Author: MartinNowak

.codecov.yml

@@ -1,6 +1,10 @@
 # Documentation: https://github.com/codecov/support/wiki/codecov.yml
 
 codecov:
+  ci:
+    - "circleci.com"
+  notify:
+    after_n_builds: 1  # send notifications after the first upload
   bot: dlang-bot
 
 coverage:

.dscanner.ini

@@ -1,7 +1,6 @@
 /etc/c/zlib/*.obj
-/etc/c/zlib/zlib.lib
+*.lib
 /phobos.json
-/phobos.lib
 
 generated
 GNUmakefile
@@ -10,9 +9,15 @@ GNUmakefile
 Makefile
 *.lst
 
+temp/
+tmp/
+
 # Rules for Xamarin Studio project data/build output
 *.dproj
 bin/
 obj/
 
+# Rule for VS Code config folder
+.vscode
+
 *.html

.gitignore

@@ -0,0 +1,76 @@
+# See also:
+# - https://github.com/blog/2392-introducing-code-owners
+# - https://help.github.com/articles/about-codeowners/
+
+# Each line is a file pattern followed by one or more owners (sorted alphabetically).
+# Please feel free to add yourself to a module or create a new mapping.
+# Ideally each module should have two or more owners.
+
+# Code owners are automatically requested for review
+# when someone opens a pull request that modifies code that they own.
+# Later matches take precedence.
+
+.dscanner.ini @wilzbach
+circleci.sh @CyberShadow @MartinNowak @wilzbach
+etc/c/* @CyberShadow
+posix.mak @CyberShadow @MartinNowak @wilzbach
+std/* @andralex
+std/algorithm/* @andralex @JackStouffer @wilzbach @ZombineDev
+std/array.d @JackStouffer @wilzbach @ZombineDev
+std/ascii.d @JackStouffer @wilzbach
+# std/base64.d
+std/bigint.d @Biotronic
+# std/bitmanip.d
+std/c/windows/* @CyberShadow
+# std/compiler.d
+std/complex.d @kyllingstad
+std/concurrency.d @MartinNowak
+std/container/ @ZombineDev
+std/conv.d @JackStouffer
+# std/csv.d
+std/datetime/* @jmdavis
+std/demangle.d @MartinNowak @rainers
+std/digest/* @jpf91
+# std/encoding.d
+# std/exception.d
+std/experimental/allocator/* @andralex @wilzbach @ZombineDev
+std/experimental/checkedint/* @andralex
+std/experimental/logger/* @burner
+# std/experimental/typecons.d
+std/file.d @CyberShadow
+# std/format.d
+# std/functional.d
+# std/getopt.d
+# std/internal/
+std/json.d @CyberShadow
+std/math* @Biotronic @ibuclaw @klickverbot
+std/meta.d @Biotronic @klickverbot @MetaLang @ZombineDev
+# std/mmfile.d
+std/net/curl.d @CyberShadow
+std/net/isemail.d @JackStouffer
+# std/numeric.d
+# std/outbuffer.d
+# std/parallelism.d
+std/path.d @CyberShadow @kyllingstad
+std/process.d @CyberShadow @kyllingstad @schveiguy
+std/random.d @WebDrake @wilzbach
+std/range/* @andralex @JackStouffer @wilzbach @ZombineDev
+std/regex/* @DmitryOlshansky
+# std/signals.d
+std/socket.d @CyberShadow @klickverbot
+# std/stdint.d
+std/stdio.d @CyberShadow @schveiguy
+std/string.d @burner @JackStouffer
+# std/system.d
+std/traits.d @Biotronic @klickverbot @ZombineDev
+std/typecons.d @Biotronic @MetaLang @ZombineDev
+# std/typetuple.d
+std/uni.d @DmitryOlshansky
+# std/uri.d
+std/utf.d @jmdavis
+std/uuid.d @jpf91
+# std/variant.d
+std/windows/* @CyberShadow
+# std/xml.d
+std/zip.d @CyberShadow
+std/zlib.d @CyberShadow

CODEOWNERS

@@ -0,0 +1,22 @@
+#!/bin/env groovy
+
+def clone (repo_url, git_ref = "master") {
+    checkout(
+        poll: false,
+        scm: [
+            $class: 'GitSCM',
+            branches: [[name: git_ref]],
+            extensions: [[$class: 'CleanBeforeCheckout']],
+            userRemoteConfigs: [[url: repo_url]]
+        ]
+    )
+}
+
+def pipeline
+node {
+    dir('dlang/ci') {
+        clone 'https://github.com/dlang/ci.git', 'master'
+    }
+    pipeline = load 'dlang/ci/pipeline.groovy'
+}
+pipeline.runPipeline()

Jenkinsfile

@@ -0,0 +1,11 @@
+`Base64URLNoPadding` (URL-safe Base64 without padding) was added
+
+$(REF Base64URLNoPadding, std, base64) allows encoding/decoding without padding:
+
+---
+import std.base64 : Base64URLNoPadding;
+
+ubyte[] data = [0x83, 0xd7, 0x30, 0x7b, 0xef];
+assert(Base64URLNoPadding.encode(data) == "g9cwe-8");
+assert(Base64URLNoPadding.decode("g9cwe-8") == data);
+---

changelog/std-base64-base64urlnopadding.dd

@@ -0,0 +1,8 @@
+`std.digest.digest` was renamed to `std.digest`.
+
+$(B Motivation):
+
+The fully qualified name of the digest function template was `std.digest.digest.digest`.
+This is because `std.digest` is a package, with a module named `digest` in it, and the function `digest` inside that.
+
+$(MREF std, digest) contains the former `std.digest.digest` package.

changelog/std-digest-package.dd

@@ -0,0 +1,9 @@
+`std.meta.Stride` was added
+
+$(REF Stride, std,meta) allows selecting a subset of template by a step size and offset:
+
+---
+alias attribs = AliasSeq!(short, int, long, ushort, uint, ulong);
+static assert(is(Stride!(3, attribs) == AliasSeq!(short, ushort)));
+static assert(is(Stride!(3, attribs[1 .. $]) == AliasSeq!(int, uint)));
+---

changelog/std-format-formattedRead-only-pointers.dd

@@ -0,0 +1,4 @@
+`Config.detached` flag for `spawnProcess` has been added
+
+`Config.detached` allows $(REF_ALTTEXT spawning processes, spawnProcess, std, process) which run independently from the current process. There is no need to wait on the processes created with this flag, and no $(HTTPS en.wikipedia.org/wiki/Zombie_process, zombie process) will be left after they exit.
+Attempts to call $(REF wait, std, process) or $(REF kill, std, process) on detached processes will throw.

changelog/std-meta-stride.dd

@@ -0,0 +1,21 @@
+`std.range.chunks` was extended to support non-forward input ranges.
+
+Now `std.range.chunks` can be used with input ranges that are not forward
+ranges, albeit with limited semantics as imposed by the underlying range.
+
+---
+import std.algorithm.comparison : equal;
+
+int i;
+
+// The generator doesn't save state, so it cannot be a forward range.
+auto inputRange = generate!(() => ++i).take(10);
+
+// We can still process it in chunks, but it will be single-pass only.
+auto chunked = inputRange.chunks(2);
+
+assert(chunked.front.equal([1, 2]));
+assert(chunked.front.empty); // Iterating the chunk has consumed it
+chunked.popFront;
+assert(chunked.front.equal([3, 4]));
+---

changelog/std-process-config-detached.dd

@@ -0,0 +1,10 @@
+`std.socket.UnixAddress` now supports abstract addresses.
+
+UNIX domain sockets are usually identified by pathnames. Linux offers a
+non-portable extension to this scheme, known as abstract socket addresses,
+which are independent of the filesystem. An abstract socket address starts with
+a null byte (`'\0'`), e.g.:
+
+---
+auto addr = new UnixAddress("\0/tmp/dbus-OtHLWmCLPR");
+---

changelog/std-random-MersenneTwisterEngine.dd

@@ -0,0 +1,9 @@
+Added possibility to use a baseclass when auto-implementing an interface
+
+A second $(REF AutoImplement, std, typecons) template has been added, which
+differs from the existing one in accepting an extra type parameter. The extra
+parameter specifies a class to derive from while auto-implementing an interface.
+
+The base class used may contain non-default constructors. Matching constructors
+will be created in the auto-implemented class and be implemented as just a call
+to super with all arguments.

changelog/std-range-bitwise.dd

@@ -6,8 +6,8 @@ dependencies:
 
 test:
   override:
-    - ./circleci.sh style
     - ./circleci.sh setup-repos
+    - ./circleci.sh style_lint
     - ./circleci.sh publictests
     - ./circleci.sh coverage:
         parallel: true

changelog/std-range-input-chunks.dd

@@ -95,12 +95,12 @@ setup_repos()
 }
 
 # verify style guide
-style()
+style_lint()
 {
     # dscanner needs a more up-to-date DMD version
     source "$(CURL_USER_AGENT=\"$CURL_USER_AGENT\" bash ~/dlang/install.sh dmd-$DSCANNER_DMD_VER --activate)"
 
-    make -f posix.mak style
+    make -f posix.mak style_lint DUB=$DUB
 }
 
 # run unittest with coverage
@@ -110,27 +110,38 @@ coverage()
     # remove all existing coverage files (just in case)
     rm -rf $(find -name '*.lst')
 
-    # currently using the test_runner yields wrong code coverage results
-    # see https://github.com/dlang/phobos/pull/4719 for details
-    ENABLE_COVERAGE="1" make -f posix.mak MODEL=$MODEL unittest-debug
+    # Coverage information of the test runner can be missing for some template instatiations.
+    # https://issues.dlang.org/show_bug.cgi?id=16397
+    # ENABLE_COVERAGE="1" make -j$N -f posix.mak MODEL=$MODEL unittest-debug
 
-    # instead we run all tests individually
-    make -f posix.mak $(find std etc -name "*.d" | sed "s/[.]d$/.test")
+    # So instead we run all tests individually (hoping that that doesn't break any tests).
+    # -cov is enabled by the %.test target itself
+    make -j$N -f posix.mak $(find std etc -name "*.d" | sed "s/[.]d$/.test/")
+
+    # Remove coverage information from lines with non-deterministic coverage.
+    # These lines are annotated with a comment containing "nocoverage".
+    sed -i 's/^ *[0-9]*\(|.*nocoverage.*\)$/       \1/' ./*.lst
 }
 
-# compile all public unittests separately
+# extract publictests and run them independently
 publictests()
 {
-    clone https://github.com/dlang/tools.git ../tools master
-    # fix to a specific version of https://github.com/dlang/tools/blob/master/phobos_tests_extractor.d
-    git -C ../tools checkout 184f5e60372d6dd36d3451b75fb6f21e23f7275b
-    make -f posix.mak publictests DUB=$DUB
+    # checkout a specific version of https://github.com/dlang/tools
+    if [ ! -d ../tools ] ; then
+        clone https://github.com/dlang/tools.git ../tools master
+    fi
+    git -C ../tools checkout df3dfa3061d25996ac98158d3bdb3525c8d89445
+
+    make -f posix.mak -j$N publictests DUB=$DUB
 }
 
 case $1 in
     install-deps) install_deps ;;
     setup-repos) setup_repos ;;
     coverage) coverage ;;
-    style) style ;;
     publictests) publictests ;;
+    style_lint) style_lint ;;
+    # has_public_example has been removed and is kept for compatibility with older PRs
+    has_public_example) echo "OK" ;;
+    *) echo "Unknown command"; exit 1;;
 esac

changelog/std-socket-abstract.dd

@@ -35,8 +35,8 @@
 
 module etc.c.curl;
 
-import core.stdc.time;
 import core.stdc.config;
+import core.stdc.time;
 import std.socket;
 
 // linux
@@ -117,7 +117,7 @@ alias curl_socket_t = socket_t;
 /// jdrewsen - Would like to get socket error constant from std.socket by it is private atm.
 version(Windows)
 {
-  private import core.sys.windows.windows, core.sys.windows.winsock2;
+  import core.sys.windows.windows, core.sys.windows.winsock2;
   enum CURL_SOCKET_BAD = SOCKET_ERROR;
 }
 version(Posix) enum CURL_SOCKET_BAD = -1;

changelog/std-stdio-readf-only-pointers.dd

@@ -18,7 +18,8 @@ flags (e.g. for dmd, `-L-lodbc` on Posix and `-Lodbc32.lib` on Windows) to link
 with the ODBC library. On Windows, using $(D pragma(lib, "odbc32")) in D
 code at top level is also appropriate.
 
-See_Also: $(LUCKY ODBC API Reference on MSN Online)
+See_Also: $(LINK2 https://docs.microsoft.com/en-us/sql/odbc/reference/syntax/odbc-api-reference,
+            ODBC API Reference on MSN Online)
 */
 
 module etc.c.odbc.sql;

changelog/std-typecons-AutoImplement.dd

@@ -8,13 +8,14 @@ original announcement)).
 
 `etc.c.odbc.sqlext` corresponds to the `sqlext.h` C header file.
 
-See_Also: $(LUCKY ODBC API Reference on MSN Online)
+See_Also: $(LINK2 https://docs.microsoft.com/en-us/sql/odbc/reference/syntax/odbc-api-reference,
+            ODBC API Reference on MSN Online)
 */
 
 module etc.c.odbc.sqlext;
 
-private import etc.c.odbc.sql;
-private import etc.c.odbc.sqltypes;
+import etc.c.odbc.sql;
+import etc.c.odbc.sqltypes;
 
 extern (Windows):
 

changelog/std-utf-decodeBack.dd

@@ -8,7 +8,8 @@ original announcement)).
 
 `etc.c.odbc.sqlext.d` corresponds to the `sqlext.h` C header file.
 
-See_Also: $(LUCKY ODBC API Reference on MSN Online)
+See_Also: $(LINK2 https://docs.microsoft.com/en-us/sql/odbc/reference/syntax/odbc-api-reference,
+          ODBC API Reference on MSN Online)
 */
 module etc.c.odbc.sqltypes;