Fix #10742: withExtension should support ranges with mutable properties (#10737)

ArthaTi · web-flow · commit 39663ea8fe72 · 2025-04-07T04:25:01.000+08:00
diff --git a/std/path.d b/std/path.d
@@ -992,7 +992,7 @@ private auto _stripDrive(R)(R path)
     Returns:
         index of extension separator (the dot), or -1 if not found
 */
-private ptrdiff_t extSeparatorPos(R)(const R path)
+private ptrdiff_t extSeparatorPos(R)(R path)
 if (isRandomAccessRange!R && hasLength!R && isSomeChar!(ElementType!R) ||
     isNarrowString!R)
 {
@@ -1280,6 +1280,11 @@ if (isSomeChar!C1 && isSomeChar!C2)
     assert(withExtension("file.ext"w.byWchar, ".").array == "file."w);
 }
 
+@safe unittest
+{
+    assert(chainPath("directory", "file").withExtension(".ext").array == buildPath("directory", "file.ext"));
+}
+
 @safe unittest
 {
     import std.algorithm.comparison : equal;

Original file line number	Diff line number	Diff line change
`@@ -992,7 +992,7 @@ private auto _stripDrive(R)(R path)`
`992`	`992`	`Returns:`
`993`	`993`	`index of extension separator (the dot), or -1 if not found`
`994`	`994`	`*/`
`995`		`-private ptrdiff_t extSeparatorPos(R)(const R path)`
	`995`	`+private ptrdiff_t extSeparatorPos(R)(R path)`
`996`	`996`	`if (isRandomAccessRange!R && hasLength!R && isSomeChar!(ElementType!R) \|\|`
`997`	`997`	`isNarrowString!R)`
`998`	`998`	`{`
`@@ -1280,6 +1280,11 @@ if (isSomeChar!C1 && isSomeChar!C2)`
`1280`	`1280`	`assert(withExtension("file.ext"w.byWchar, ".").array == "file."w);`
`1281`	`1281`	`}`
`1282`	`1282`
	`1283`	`+@safe unittest`
	`1284`	`+{`
	`1285`	`+ assert(chainPath("directory", "file").withExtension(".ext").array == buildPath("directory", "file.ext"));`
	`1286`	`+}`
	`1287`	`+`
`1283`	`1288`	`@safe unittest`
`1284`	`1289`	`{`
`1285`	`1290`	`import std.algorithm.comparison : equal;`