Skip to content

Microsoft.Data.Sqlite: Support Half #30931

New issue
New issue
Open
Feature
#35328
Open
Microsoft.Data.Sqlite: Support Half#30931
Feature
#35328
Labels
area-adonet-sqlitegood first issueThis issue should be relatively straightforward to fix.
Milestone
Backlog
@bricelam

Description

@bricelam
bricelam
opened on May 19, 2023
Contributor

Similar to how we handle float, we could use REAL in the database for these values.

Activity

bricelam
added
type-enhancement
area-adonet-sqlite
good first issueThis issue should be relatively straightforward to fix.
on May 19, 2023
ilmalte

ilmalte commented on May 19, 2023

@ilmalte
ilmalte
on May 19, 2023
Contributor

Hey @bricelam, may I give a try to work on this?

Do you see this implementation for Sqlite only?

If so, I was thinking about starting from this class and create the mapping for the type.
src/EFCore.Sqlite.Core/Storage/Internal/SqliteTypeMappingSource.cs

Then I would cover the new type in the test Create_and_clone_with_converter.

efcore/test/EFCore.Sqlite.Tests/Storage/SqliteTypeMappingTest.cs

Line 78 in 6b97368

public override void Create_and_clone_with_converter(Type mappingType, Type type)

Any guidance, suggestion or heads up?

bricelam

bricelam commented on May 19, 2023

@bricelam
bricelam
on May 19, 2023 · edited by bricelam
ContributorAuthor

@ilmalte Sure, feel free to work on it! Yes, this issue is just about SQLite.

First, you'll need to add support for it in the ADO.NET provider. Just follow what we do for float. Here's the code for reading values: (Note, there's a bit of duplication required in this method.)

efcore/src/Microsoft.Data.Sqlite.Core/SqliteValueReader.cs

Lines 202 to 205 in c983103

if (typeof(T) == typeof(float))
{
return (T)(object)GetFloat(ordinal);
}

And, here's the code for writing:

efcore/src/Microsoft.Data.Sqlite.Core/SqliteValueBinder.cs

Lines 161 to 165 in c983103

else if (type == typeof(float))
{
var value = (double)(float)_value;
BindDouble(value);
}

Then yeah, for the EF Core changes, the type mapper is the right place.

We should also update the scaffolding code which uses heuristics to determine the CLR type:

efcore/src/EFCore.Sqlite.Core/Scaffolding/Internal/SqliteDatabaseModelFactory.cs

Lines 696 to 707 in c983103

if (_floatTypes.Contains(baseColumnType))
{
if (min >= float.MinValue
&& max <= float.MaxValue)
{
column["ClrType"] = typeof(float);
continue;
}
_logger.OutOfRangeWarning(column.Name, table.Name, "float");
}

ajcvickers
added this to the Backlog milestone on May 24, 2023
ilmalte
added a commit that references this issue on Jul 21, 2023

feat: support half for Sqlite

6fcd0d7
newmasterSG
mentioned this on Nov 25, 2024
cincuranet
mentioned this on Dec 11, 2024
newmasterSG
linked a pull request that will close this issue on Dec 13, 2024
roji
removed
type-enhancement
on Jun 15, 2025
roji
added the
Feature
issue type on Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-adonet-sqlitegood first issueThis issue should be relatively straightforward to fix.

    Type

    Feature

    Projects

    No projects

    Milestone

    Relationships

    None yet

      Development

      Participants

      @bricelam@ajcvickers@roji@ilmalte

      Issue actions
        Microsoft.Data.Sqlite: Support Half · Issue #30931 · dotnet/efcore