Skip to content

Should we throw warning instead of error while patched packages not exist #339

Open
@joe223

Description

@joe223

As a example:

Patch file found for package vite which is not present at node_modules/vite

If we want to build sub-packages independently in monorepo, but we already set root/package.json

"scripts": {
   "postinstall": "patch-package"
 }

that will interrupt the build process if submodule root/packages/module-a does not dependent vite

Activity

marcogigliarano

marcogigliarano commented on Oct 11, 2021

@marcogigliarano

Any update on this? I think I'm facing the same problem with another module.
I work with Lerna monorepo and this issue is just on Gitlab CI, locally it's working.

nickfla1-mxm

nickfla1-mxm commented on Nov 11, 2021

@nickfla1-mxm

+1, would be a nice addition. A cli flag like --skip-not-found / --skip-missing, enabling it would just print a warning instead of an exception. Without it, it would default to the current behaviour.

xziy

xziy commented on Aug 19, 2022

@xziy

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @marcogigliarano@joe223@xziy@nickfla1-mxm

      Issue actions

        Should we throw warning instead of error while patched packages not exist · Issue #339 · ds300/patch-package