You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I left with the logic that if not supplied it will set 'undefined' which will produce the behaviour you have today. This means it will not break existing implementations but technically the default behavour should be to set it as step="2" and set undefined as a fallback if option "step":"undefined" is set. This is just my opinion as the default time picker in my opinion should be to set a valid ISO time.
Activity
kairos0ne commentedon May 26, 2025
I think the html render just needs the step attribute
step="2"
sdirix commentedon May 26, 2025
Thanks for the report. Can you contribute the fix?
kairos0ne commentedon May 26, 2025
Yeah np, however I have a question.
Do you want to simply add the attribute step="2" or do you want to add dynamically with an option ?
kairos0ne commentedon May 26, 2025
I tried to push a fix but I'm not listed contributer...
if you change the TimeControlRenderer.vue it requires a 1 line change
:step="appliedOptions.step > 0 ? appliedOptions.step : undefined"
That way you can support both.
kairos0ne commentedon May 27, 2025
here is the pull #2453
I left with the logic that if not supplied it will set 'undefined' which will produce the behaviour you have today. This means it will not break existing implementations but technically the default behavour should be to set it as step="2" and set undefined as a fallback if option "step":"undefined" is set. This is just my opinion as the default time picker in my opinion should be to set a valid ISO time.
Best
Scott