Skip to content

Use stricter type checks #635

Open
@microdev1

Description

@microdev1

Hi, I've ported Sonner to SolidJS in my fork microdev1/sonner-solidjs and encountered some type ambiguities when using stricter type checks. I was wondering if we could incorporate similar changes upstream—I’d be happy to help implement them.

As a side note, it would be great if SolidJS can be supported in upstream, though that could be discussed in a separate issue.

Activity

emilkowalski

emilkowalski commented on May 16, 2025

@emilkowalski
Owner

Sure, feel free to submit a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @emilkowalski@microdev1

      Issue actions

        Use stricter type checks · Issue #635 · emilkowalski/sonner