Skip to content

Maintain persistence for firebaseToken in AuthImpl object #9119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: gcip-byociam-web
Choose a base branch
from

Conversation

mansisampat
Copy link
Contributor

@mansisampat mansisampat commented Jun 25, 2025

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Maintain persistence for firebaseToken in AuthImpl object.

Testing

Copy link

changeset-bot bot commented Jun 25, 2025

⚠️ No Changeset found

Latest commit: 97752d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 25, 2025

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (15b2302)Merge (e199ba1)Diff
    browser196 kB198 kB+1.42 kB (+0.7%)
    cordova169 kB170 kB+1.42 kB (+0.8%)
    main150 kB152 kB+1.42 kB (+0.9%)
    module196 kB198 kB+1.42 kB (+0.7%)
    react-native168 kB170 kB+1.42 kB (+0.8%)
  • @firebase/auth-cordova

    TypeBase (15b2302)Merge (e199ba1)Diff
    browser169 kB170 kB+1.42 kB (+0.8%)
    module169 kB170 kB+1.42 kB (+0.8%)
  • @firebase/auth-web-extension

    TypeBase (15b2302)Merge (e199ba1)Diff
    browser145 kB147 kB+1.42 kB (+1.0%)
    main163 kB164 kB+1.42 kB (+0.9%)
    module145 kB147 kB+1.42 kB (+1.0%)
  • @firebase/auth/internal

    TypeBase (15b2302)Merge (e199ba1)Diff
    browser207 kB208 kB+1.42 kB (+0.7%)
    main177 kB178 kB+1.42 kB (+0.8%)
    module207 kB208 kB+1.42 kB (+0.7%)
  • bundle

    TypeBase (15b2302)Merge (e199ba1)Diff
    auth (Anonymous)78.9 kB80.0 kB+1.14 kB (+1.5%)
    auth (EmailAndPassword)89.0 kB90.1 kB+1.14 kB (+1.3%)
    auth (GoogleFBTwitterGitHubPopup)110 kB112 kB+1.14 kB (+1.0%)
    auth (GooglePopup)103 kB104 kB+1.14 kB (+1.1%)
    auth (GoogleRedirect)103 kB104 kB+1.14 kB (+1.1%)
    auth (Phone)96.4 kB97.6 kB+1.14 kB (+1.2%)
  • firebase

    TypeBase (15b2302)Merge (e199ba1)Diff
    firebase-auth-compat.js146 kB147 kB+1.06 kB (+0.7%)
    firebase-auth-cordova.js145 kB146 kB+1.14 kB (+0.8%)
    firebase-auth-web-extension.js127 kB129 kB+1.14 kB (+0.9%)
    firebase-auth.js165 kB166 kB+1.14 kB (+0.7%)
    firebase-compat.js803 kB804 kB+1.06 kB (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xAzUDMoGYH.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 25, 2025

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • ActionCodeOperation

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.7 kB42.9 kB+1.14 kB (+2.7%)
      size-with-ext-deps63.8 kB64.9 kB+1.14 kB (+1.8%)
    • ActionCodeURL

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size42.6 kB43.7 kB+1.14 kB (+2.7%)
      size-with-ext-deps64.8 kB66.0 kB+1.14 kB (+1.8%)
    • AuthCredential

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.7 kB42.9 kB+1.14 kB (+2.7%)
      size-with-ext-deps63.8 kB64.9 kB+1.14 kB (+1.8%)
    • AuthErrorCodes

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size46.7 kB47.8 kB+1.14 kB (+2.5%)
      size-with-ext-deps68.7 kB69.9 kB+1.14 kB (+1.7%)
    • EmailAuthCredential

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size49.3 kB50.4 kB+1.14 kB (+2.3%)
      size-with-ext-deps71.4 kB72.5 kB+1.14 kB (+1.6%)
    • EmailAuthProvider

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size50.7 kB51.9 kB+1.14 kB (+2.3%)
      size-with-ext-deps73.0 kB74.2 kB+1.14 kB (+1.6%)
    • FacebookAuthProvider

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size46.5 kB47.7 kB+1.14 kB (+2.5%)
      size-with-ext-deps68.6 kB69.7 kB+1.14 kB (+1.7%)
    • FactorId

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.5 kB42.6 kB+1.14 kB (+2.8%)
      size-with-ext-deps63.6 kB64.7 kB+1.14 kB (+1.8%)
    • GithubAuthProvider

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size46.5 kB47.7 kB+1.14 kB (+2.5%)
      size-with-ext-deps68.6 kB69.7 kB+1.14 kB (+1.7%)
    • GoogleAuthProvider

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size46.5 kB47.7 kB+1.14 kB (+2.5%)
      size-with-ext-deps68.6 kB69.7 kB+1.14 kB (+1.7%)
    • OAuthCredential

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size43.6 kB44.8 kB+1.14 kB (+2.6%)
      size-with-ext-deps65.7 kB66.8 kB+1.14 kB (+1.7%)
    • OAuthProvider

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size47.5 kB48.6 kB+1.14 kB (+2.4%)
      size-with-ext-deps69.5 kB70.7 kB+1.14 kB (+1.6%)
    • OperationType

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.5 kB42.7 kB+1.14 kB (+2.8%)
      size-with-ext-deps63.6 kB64.7 kB+1.14 kB (+1.8%)
    • PhoneAuthCredential

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size43.6 kB44.8 kB+1.14 kB (+2.6%)
      size-with-ext-deps65.7 kB66.8 kB+1.14 kB (+1.7%)
    • PhoneAuthProvider

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size53.0 kB54.1 kB+1.14 kB (+2.2%)
      size-with-ext-deps75.0 kB76.2 kB+1.14 kB (+1.5%)
    • PhoneMultiFactorGenerator

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size42.3 kB43.5 kB+1.14 kB (+2.7%)
      size-with-ext-deps64.4 kB65.5 kB+1.14 kB (+1.8%)
    • ProviderId

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.6 kB42.7 kB+1.14 kB (+2.8%)
      size-with-ext-deps63.6 kB64.8 kB+1.14 kB (+1.8%)
    • RecaptchaVerifier

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size48.5 kB49.6 kB+1.14 kB (+2.4%)
      size-with-ext-deps70.5 kB71.7 kB+1.14 kB (+1.6%)
    • SAMLAuthProvider

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size47.8 kB48.9 kB+1.14 kB (+2.4%)
      size-with-ext-deps69.9 kB71.0 kB+1.14 kB (+1.6%)
    • SignInMethod

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.6 kB42.8 kB+1.14 kB (+2.7%)
      size-with-ext-deps63.7 kB64.8 kB+1.14 kB (+1.8%)
    • TotpMultiFactorGenerator

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size44.0 kB45.1 kB+1.14 kB (+2.6%)
      size-with-ext-deps66.1 kB67.2 kB+1.14 kB (+1.7%)
    • TotpSecret

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size42.4 kB43.6 kB+1.14 kB (+2.7%)
      size-with-ext-deps64.5 kB65.6 kB+1.14 kB (+1.8%)
    • TwitterAuthProvider

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size46.5 kB47.7 kB+1.14 kB (+2.5%)
      size-with-ext-deps68.6 kB69.7 kB+1.14 kB (+1.7%)
    • applyActionCode

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.6 kB42.7 kB+1.14 kB (+2.8%)
      size-with-ext-deps63.6 kB64.8 kB+1.14 kB (+1.8%)
    • beforeAuthStateChanged

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.5 kB42.7 kB+1.14 kB (+2.8%)
      size-with-ext-deps63.6 kB64.7 kB+1.14 kB (+1.8%)
    • browserCookiePersistence

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size43.4 kB44.6 kB+1.14 kB (+2.6%)
      size-with-ext-deps65.5 kB66.6 kB+1.14 kB (+1.7%)
    • browserLocalPersistence

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size44.5 kB45.7 kB+1.14 kB (+2.6%)
      size-with-ext-deps66.6 kB67.8 kB+1.14 kB (+1.7%)
    • browserPopupRedirectResolver

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size66.0 kB67.2 kB+1.14 kB (+1.7%)
      size-with-ext-deps88.3 kB89.5 kB+1.14 kB (+1.3%)
    • browserSessionPersistence

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size44.5 kB45.7 kB+1.14 kB (+2.6%)
      size-with-ext-deps66.6 kB67.8 kB+1.14 kB (+1.7%)
    • checkActionCode

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size42.7 kB43.8 kB+1.14 kB (+2.7%)
      size-with-ext-deps64.8 kB65.9 kB+1.14 kB (+1.8%)
    • confirmPasswordReset

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.8 kB43.0 kB+1.14 kB (+2.7%)
      size-with-ext-deps63.9 kB65.0 kB+1.14 kB (+1.8%)
    • connectAuthEmulator

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size43.5 kB44.6 kB+1.14 kB (+2.6%)
      size-with-ext-deps70.2 kB71.4 kB+1.14 kB (+1.6%)
    • createUserWithEmailAndPassword

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size48.5 kB49.6 kB+1.14 kB (+2.4%)
      size-with-ext-deps70.5 kB71.7 kB+1.14 kB (+1.6%)
    • debugErrorMap

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size53.9 kB55.1 kB+1.14 kB (+2.1%)
      size-with-ext-deps76.0 kB77.1 kB+1.14 kB (+1.5%)
    • deleteUser

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.5 kB42.6 kB+1.14 kB (+2.8%)
      size-with-ext-deps63.6 kB64.7 kB+1.14 kB (+1.8%)
    • exchangeToken

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size42.3 kB43.5 kB+1.14 kB (+2.7%)
      size-with-ext-deps64.4 kB65.5 kB+1.14 kB (+1.8%)
    • fetchSignInMethodsForEmail

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.8 kB43.0 kB+1.14 kB (+2.7%)
      size-with-ext-deps63.9 kB65.0 kB+1.14 kB (+1.8%)
    • getAdditionalUserInfo

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size42.8 kB44.0 kB+1.14 kB (+2.7%)
      size-with-ext-deps64.9 kB66.0 kB+1.14 kB (+1.8%)
    • getAuth

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size76.5 kB77.6 kB+1.14 kB (+1.5%)
      size-with-ext-deps110 kB111 kB+1.14 kB (+1.0%)
    • getIdToken

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.5 kB42.7 kB+1.14 kB (+2.8%)
      size-with-ext-deps63.6 kB64.7 kB+1.14 kB (+1.8%)
    • getIdTokenResult

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.5 kB42.6 kB+1.14 kB (+2.8%)
      size-with-ext-deps63.5 kB64.7 kB+1.14 kB (+1.8%)
    • getMultiFactorResolver

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size44.4 kB45.5 kB+1.14 kB (+2.6%)
      size-with-ext-deps66.4 kB67.6 kB+1.14 kB (+1.7%)
    • getRedirectResult

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size49.1 kB50.3 kB+1.14 kB (+2.3%)
      size-with-ext-deps71.2 kB72.4 kB+1.14 kB (+1.6%)
    • inMemoryPersistence

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.5 kB42.6 kB+1.14 kB (+2.8%)
      size-with-ext-deps63.5 kB64.7 kB+1.14 kB (+1.8%)
    • indexedDBLocalPersistence

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size48.9 kB50.1 kB+1.14 kB (+2.3%)
      size-with-ext-deps71.0 kB72.1 kB+1.14 kB (+1.6%)
    • initializeAuth

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.7 kB42.9 kB+1.14 kB (+2.7%)
      size-with-ext-deps64.3 kB65.4 kB+1.14 kB (+1.8%)
    • initializeRecaptchaConfig

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size45.2 kB46.4 kB+1.14 kB (+2.5%)
      size-with-ext-deps67.3 kB68.4 kB+1.14 kB (+1.7%)
    • isSignInWithEmailLink

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size42.7 kB43.8 kB+1.14 kB (+2.7%)
      size-with-ext-deps65.0 kB66.1 kB+1.14 kB (+1.8%)
    • linkWithCredential

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size42.5 kB43.7 kB+1.14 kB (+2.7%)
      size-with-ext-deps64.6 kB65.7 kB+1.14 kB (+1.8%)
    • linkWithPhoneNumber

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size53.7 kB54.9 kB+1.14 kB (+2.1%)
      size-with-ext-deps75.8 kB76.9 kB+1.14 kB (+1.5%)
    • linkWithPopup

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size52.7 kB53.8 kB+1.14 kB (+2.2%)
      size-with-ext-deps74.8 kB75.9 kB+1.14 kB (+1.5%)
    • linkWithRedirect

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size47.8 kB49.0 kB+1.14 kB (+2.4%)
      size-with-ext-deps69.9 kB71.0 kB+1.14 kB (+1.6%)
    • multiFactor

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size43.7 kB44.8 kB+1.14 kB (+2.6%)
      size-with-ext-deps65.7 kB66.9 kB+1.14 kB (+1.7%)
    • onAuthStateChanged

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.5 kB42.7 kB+1.14 kB (+2.8%)
      size-with-ext-deps63.6 kB64.7 kB+1.14 kB (+1.8%)
    • onIdTokenChanged

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.5 kB42.7 kB+1.14 kB (+2.8%)
      size-with-ext-deps63.6 kB64.7 kB+1.14 kB (+1.8%)
    • parseActionCodeURL

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size42.6 kB43.7 kB+1.14 kB (+2.7%)
      size-with-ext-deps64.9 kB66.0 kB+1.14 kB (+1.8%)
    • prodErrorMap

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.5 kB42.6 kB+1.14 kB (+2.8%)
      size-with-ext-deps63.5 kB64.7 kB+1.14 kB (+1.8%)
    • reauthenticateWithCredential

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size43.1 kB44.3 kB+1.14 kB (+2.7%)
      size-with-ext-deps65.2 kB66.3 kB+1.14 kB (+1.8%)
    • reauthenticateWithPhoneNumber

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size54.3 kB55.5 kB+1.14 kB (+2.1%)
      size-with-ext-deps76.4 kB77.6 kB+1.14 kB (+1.5%)
    • reauthenticateWithPopup

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size52.8 kB53.9 kB+1.14 kB (+2.2%)
      size-with-ext-deps74.9 kB76.0 kB+1.14 kB (+1.5%)
    • reauthenticateWithRedirect

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size47.6 kB48.8 kB+1.14 kB (+2.4%)
      size-with-ext-deps69.7 kB70.8 kB+1.14 kB (+1.6%)
    • reload

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.5 kB42.6 kB+1.14 kB (+2.8%)
      size-with-ext-deps63.5 kB64.7 kB+1.14 kB (+1.8%)
    • revokeAccessToken

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.5 kB42.7 kB+1.14 kB (+2.8%)
      size-with-ext-deps63.6 kB64.7 kB+1.14 kB (+1.8%)
    • sendEmailVerification

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size42.5 kB43.7 kB+1.14 kB (+2.7%)
      size-with-ext-deps64.6 kB65.7 kB+1.14 kB (+1.8%)
    • sendPasswordResetEmail

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size48.1 kB49.3 kB+1.14 kB (+2.4%)
      size-with-ext-deps70.2 kB71.3 kB+1.14 kB (+1.6%)
    • sendSignInLinkToEmail

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size48.2 kB49.3 kB+1.14 kB (+2.4%)
      size-with-ext-deps70.3 kB71.4 kB+1.14 kB (+1.6%)
    • setPersistence

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.5 kB42.7 kB+1.14 kB (+2.8%)
      size-with-ext-deps63.6 kB64.7 kB+1.14 kB (+1.8%)
    • signInAnonymously

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size42.7 kB43.8 kB+1.14 kB (+2.7%)
      size-with-ext-deps64.7 kB65.9 kB+1.14 kB (+1.8%)
    • signInWithCredential

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size42.9 kB44.0 kB+1.14 kB (+2.7%)
      size-with-ext-deps65.0 kB66.1 kB+1.14 kB (+1.8%)
    • signInWithCustomToken

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size42.5 kB43.7 kB+1.14 kB (+2.7%)
      size-with-ext-deps64.6 kB65.7 kB+1.14 kB (+1.8%)
    • signInWithEmailAndPassword

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size52.5 kB53.6 kB+1.14 kB (+2.2%)
      size-with-ext-deps74.8 kB75.9 kB+1.14 kB (+1.5%)
    • signInWithEmailLink

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size52.5 kB53.6 kB+1.14 kB (+2.2%)
      size-with-ext-deps74.8 kB75.9 kB+1.14 kB (+1.5%)
    • signInWithPhoneNumber

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size54.1 kB55.3 kB+1.14 kB (+2.1%)
      size-with-ext-deps76.2 kB77.3 kB+1.14 kB (+1.5%)
    • signInWithPopup

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size52.7 kB53.9 kB+1.14 kB (+2.2%)
      size-with-ext-deps74.8 kB76.0 kB+1.14 kB (+1.5%)
    • signInWithRedirect

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size47.3 kB48.5 kB+1.14 kB (+2.4%)
      size-with-ext-deps69.4 kB70.5 kB+1.14 kB (+1.6%)
    • signOut

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.5 kB42.6 kB+1.14 kB (+2.8%)
      size-with-ext-deps63.6 kB64.7 kB+1.14 kB (+1.8%)
    • unlink

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size42.1 kB43.2 kB+1.14 kB (+2.7%)
      size-with-ext-deps64.1 kB65.3 kB+1.14 kB (+1.8%)
    • updateCurrentUser

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.5 kB42.7 kB+1.14 kB (+2.8%)
      size-with-ext-deps63.6 kB64.7 kB+1.14 kB (+1.8%)
    • updateEmail

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.8 kB43.0 kB+1.14 kB (+2.7%)
      size-with-ext-deps63.9 kB65.0 kB+1.14 kB (+1.8%)
    • updatePassword

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.8 kB42.9 kB+1.14 kB (+2.7%)
      size-with-ext-deps63.8 kB65.0 kB+1.14 kB (+1.8%)
    • updatePhoneNumber

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size42.3 kB43.4 kB+1.14 kB (+2.7%)
      size-with-ext-deps64.4 kB65.5 kB+1.14 kB (+1.8%)
    • updateProfile

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size42.0 kB43.1 kB+1.14 kB (+2.7%)
      size-with-ext-deps64.0 kB65.2 kB+1.14 kB (+1.8%)
    • useDeviceLanguage

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.5 kB42.7 kB+1.14 kB (+2.8%)
      size-with-ext-deps63.6 kB64.7 kB+1.14 kB (+1.8%)
    • validatePassword

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size41.5 kB42.7 kB+1.14 kB (+2.8%)
      size-with-ext-deps63.6 kB64.7 kB+1.14 kB (+1.8%)
    • verifyBeforeUpdateEmail

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size42.5 kB43.7 kB+1.14 kB (+2.7%)
      size-with-ext-deps64.6 kB65.8 kB+1.14 kB (+1.8%)
    • verifyPasswordResetCode

      Size

      TypeBase (15b2302)Merge (e199ba1)Diff
      size42.8 kB43.9 kB+1.14 kB (+2.7%)
      size-with-ext-deps64.8 kB66.0 kB+1.14 kB (+1.8%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bTxEZzYxD8.html

if (firebaseToken) {
await this.assertedPersistence.setFirebaseToken(firebaseToken);
} else {
await this.assertedPersistence.removeFirebaseToken();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will have to do same for signOut as well right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. I plan to create a separate CL for signOut logic. Please let me know if you see any concerns.

@mansisampat mansisampat requested a review from a team as a code owner June 27, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants