React 19 Upgrade (Based #1031) #1036
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request upgrades the project to React 19 while preserving Storybook functionality by updating dependencies and configurations.
- Update peer dependencies in packages to include React 19 support.
- Add a new test script and workflow job for React 19 testing.
- Upgrade Storybook and its addons along with updating related configuration files.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| setup-react-19-test.sh | New script to install React 19 and related testing libraries. |
| packages/source/package.json | Updated peerDependencies to include React 19. |
| packages/core/package.json | Updated peerDependencies to include React 19. |
| packages/cells/package.json | Added peerDependencies for React 19 support. |
| package.json | Upgraded React, Storybook, testing libraries and added new scripts. |
| README.md | Updated badge and instructions to reflect React 19 support. |
| .storybook/preview.ts | Added docs settings for enhanced code panel functionality. |
| .storybook/main.ts | Revised Storybook configuration using the new addon-docs. |
| .storybook/main.js | Removed in favor of the TypeScript configuration. |
| .github/workflows/node.js.yml | Added a workflow job for running tests under React 19. |
Comments suppressed due to low confidence (2)
package.json:102
- Clarify the purpose and origin of the "$storybook" override. Consider adding a brief comment or documentation to indicate why this alias is used and how it ensures proper dependency resolution.
"overrides": { "storybook": "$storybook" }
.storybook/main.ts:7
- [nitpick] The configuration now only includes the addon-docs. Verify that removal of the previously included addons (e.g., addon-controls and addon-storysource) is intentional and that no required functionality is lost.
addons: [getAbsolutePath("@storybook/addon-docs")],
| addons: [getAbsolutePath("@storybook/addon-storysource"), getAbsolutePath("@storybook/addon-controls")], | ||
| addons: [getAbsolutePath("@storybook/addon-docs")], |
There was a problem hiding this comment.
Are these storybook addons equivalent?
There was a problem hiding this comment.
@storybook/addon-storysource has been completely removed in Storybook 9.0. It previously provided source code viewing capabilities for stories, now @storybook/addon-docs is responsible for that.
@storybook/addon-controls has been moved to Storybook core and is no longer needed as a separate package.
https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#storysource-addon-removed
https://storybook.js.org/docs/addons/addon-migration-guide#package-consolidation
Based on PR #1031 by @DGarbs51, this adds React 19 support while preserving Storybook functionality through proper dependency upgrades.
What's Changed
✅ React 19 Upgrade: Updated to React 19.1.0 and React DOM 19.1.0 (from #1031)
✅ Storybook Preserved: Instead of removing Storybook, upgraded it and related dependencies for React 19 compatibility
While the original #1031 removed Storybook due to React 19 compatibility issues, this version preserves the complete development workflow by upgrading Storybook to a version that supports React 19.