Skip to content

Support custom HTTP headers for CONNECT proxy request #479

New issue
New issue
Open
#988
#605
Open
Support custom HTTP headers for CONNECT proxy request#479
#988
#605
Labels
feature request
@aus

Description

@aus
aus
opened on Feb 9, 2019

When an HTTP proxy is used, there is no way to customize the headers in the initial CONNECT request. In some situations, a HTTP proxy may require certain User-Agents or other headers. golang added support for this in net/http in 1.8. The golang issue is documented here with support added in 1.8 as documented here.

Note, this is not the same as providing a requestHeader to Conn.NewClient or Dialer.Dial. These headers are only present after the initial CONNECT request to the HTTP proxy.

Activity

aus
mentioned this on Feb 9, 2019
ghost added
help wanted
on Feb 10, 2019
elithrar
added
feature request
waiting on new maintainer
on Jun 30, 2019
Fenny

Fenny commented on Dec 9, 2019

@Fenny
Fenny
on Dec 9, 2019 · edited by Fenny

Untill this feature gets properly implemented into the main branch, you can use my version.
https://github.com/fenny/websocket

dialer := websocket.Dialer{
  Proxy: http.ProxyURL(&url.URL{
    Scheme: "http",
    Host: "127.0.0.1:6969",
    Path: "/",
  }),
  ProxyConnectHeaders: map[string]string{
    "Proxy-Auth": "user:pass",
    "Proxy-Geo":  "EU",
  },
}
Fenny
mentioned this on Dec 10, 2019
AllenX2018
added 2 commits that reference this issue on Jun 15, 2020

Feature issue gorilla#479

c4646c6

Fix issue gorilla#479

8bc7e24
AllenX2018
mentioned this on Jun 16, 2020
AllenX2018
linked a pull request that will close this issue on Jun 29, 2020
AllenX2018
added a commit that references this issue on Sep 11, 2020

fix issue gorilla#479

aa46640
elithrar
added
waiting on new maintainer
and removed
waiting on new maintainer
on Sep 12, 2020
ghost removed
help wanted
on Jan 8, 2022
coreydaley
added this to Gorilla Web Toolkiton Jul 10, 2023
coreydaley
removed
waiting on new maintainer
on Jul 16, 2023
coreydaley
moved this to 🏗 In progress in Gorilla Web Toolkiton Jul 23, 2023
michel-laterman
mentioned this on May 26, 2025
michel-laterman

michel-laterman commented on Jun 3, 2025

@michel-laterman
michel-laterman
on Jun 3, 2025 · edited by michel-laterman

@AlexVulaj, I'm interested in moving this issue forward. There's an implementation PR that looks like it's no longer maintained (#605). What should the approach be when it comes to getting the PR in a mergable state?

EDIT: I went ahead and created another PR #988

michel-laterman
linked a pull request that will close this issue on Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature request

    Type

    No type

    Projects

    Gorilla Web Toolkit

    Status

    🏗 In progress

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @elithrar@aus@coreydaley@Fenny@michel-laterman

      Issue actions
        Support custom HTTP headers for CONNECT proxy request · Issue #479 · gorilla/websocket