Skip to content

add cleanup websocket messages button #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025

Conversation

ceifa
Copy link
Contributor

@ceifa ceifa commented Jun 5, 2025

A clear messages button, like browsers network inspect have

@ceifa ceifa force-pushed the cleanup-messages-button branch from 611a6c6 to a0d1985 Compare June 5, 2025 16:51
@pimterry pimterry merged commit 4b9b830 into httptoolkit:main Jun 23, 2025
7 checks passed
@pimterry
Copy link
Member

Thanks! I did a little clearup here (the requirement to use .downstream should have been a type error, but wasn't - the 'view' upstream/downstream thing for WebSockets is new and isn't really widely used yet) so I've fixed that first, and I've tweaked the delete icon to match the rest, but otherwise all looks good I think! 👍

@ceifa
Copy link
Contributor Author

ceifa commented Jun 23, 2025

I was a little bit confused about how the types are structured, thank you for fixing it! The idea of the icon is that it matches the icon chromium uses for the same feature, but the one you used is good too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants