-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
bugDid we break something?Did we break something?p2-mediumMedium priority, should be done, but less importantMedium priority, should be done, but less important
Description
From reading dvc/config.py
I see that configpath
option of S3 configuration is not included into Config._map_dirs()
. This will mean that any relative paths there would be resolved concerning current dir not the dir config file is in.
So the fix is to include configpath
into Config._map_dirs()
.
The more complex fix, which will save from future errors of this type is removing duplication. I.e. using some subtype of str
, in dvc/config_schema.py
to mark things to be handled specially. Deducing schema in Config._map_dirs()
automatically.
Metadata
Metadata
Assignees
Labels
bugDid we break something?Did we break something?p2-mediumMedium priority, should be done, but less importantMedium priority, should be done, but less important
Type
Projects
Status
Done
Milestone
Relationships
Development
Select code repository
Activity
shcheklein commentedon May 17, 2021
@Suor what is the priority for this from the Studio perspective?
Suor commentedon May 17, 2021
Not an issue for Studio. I found it reading dvc code for an unrelated issue, which I've already fixed.