Skip to content

S3 configpath is not properly treated as a relpath #6020

@Suor

Description

@Suor
Contributor

From reading dvc/config.py I see that configpath option of S3 configuration is not included into Config._map_dirs(). This will mean that any relative paths there would be resolved concerning current dir not the dir config file is in.

So the fix is to include configpath into Config._map_dirs().

The more complex fix, which will save from future errors of this type is removing duplication. I.e. using some subtype of str, in dvc/config_schema.py to mark things to be handled specially. Deducing schema in Config._map_dirs() automatically.

Activity

shcheklein

shcheklein commented on May 17, 2021

@shcheklein
Member

@Suor what is the priority for this from the Studio perspective?

Suor

Suor commented on May 17, 2021

@Suor
ContributorAuthor

Not an issue for Studio. I found it reading dvc code for an unrelated issue, which I've already fixed.

added
bugDid we break something?
p2-mediumMedium priority, should be done, but less important
on May 17, 2021
moved this from Backlog to Done in DVCon Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugDid we break something?p2-mediumMedium priority, should be done, but less important

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @Suor@shcheklein@efiop@mattseddon

      Issue actions

        S3 configpath is not properly treated as a relpath · Issue #6020 · iterative/dvc