Skip to content

alwaysOpen not working proper when we used adjustToContentHeight #172

@ydv0121

Description

@ydv0121

Hello
First of all thank you for this awesome work.
I am facing one issue when i am using alwaysOpen and adjustToContentHeight together.
i passed alwaysOpen={100} and set adjustToContentHeight={true}.

so when after page load Modal render with default adjustToContentHeight size.
it should render with 100 which i passed in alwaysOpen

please tell me if i am missing something

Activity

jeremybarbet

jeremybarbet commented on Apr 12, 2020

@jeremybarbet
Owner

Hi,

You are not missing anything, I just didn't test this case. It might be tricky to handle both cases together, I will try to look at it when I'm done with my list.

jeremybarbet

jeremybarbet commented on Apr 25, 2020

@jeremybarbet
Owner

Fixed and release in rc-25

ydv0121

ydv0121 commented on Apr 25, 2020

@ydv0121
Author

Fixed and release in rc-25

Damn you are flash🤘😅.
will try it.
Thank you man

ydv0121

ydv0121 commented on Apr 27, 2020

@ydv0121
Author

Hello @jeremybarbet
i am getting still same issue in rc-25
Modalize open default with adjustToContentHeight when using with alwaysOpen

My react-native version is 0.58.4

jeremybarbet

jeremybarbet commented on Apr 28, 2020

@jeremybarbet
Owner

https://b.ueno.is/WnuGlBAQ

Is that not what you were talking about? that adjustToContentHeight wasn't working while being used along with alwaysOpen props?

ydv0121

ydv0121 commented on Apr 30, 2020

@ydv0121
Author

https://b.ueno.is/WnuGlBAQ

Is that not what you were talking about? that adjustToContentHeight wasn't working while being used along with alwaysOpen props?

its working now..issue with my node_modules or what i don't know but i reinstall the lib and its working now perfectly. Thank you man..Thanks

jeremybarbet

jeremybarbet commented on Apr 30, 2020

@jeremybarbet
Owner

Sweet, good to hear!

eladgel

eladgel commented on Apr 27, 2021

@eladgel

@jeremybarbet There is an issue when you add HeaderComponent in this scenario where the action sheet doesn't open at all...

nirajniroula

nirajniroula commented on Nov 9, 2021

@nirajniroula

When HeaderComponent is passed, this issue is still there. You should either remove the HeaderComponent prop or the adjustToContentHeight prop to make the alwaysOpen prop work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @eladgel@jeremybarbet@nirajniroula@ydv0121

      Issue actions

        alwaysOpen not working proper when we used adjustToContentHeight · Issue #172 · jeremybarbet/react-native-modalize