You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello
First of all thank you for this awesome work.
I am facing one issue when i am using alwaysOpen and adjustToContentHeight together.
i passed alwaysOpen={100} and set adjustToContentHeight={true}.
so when after page load Modal render with default adjustToContentHeight size.
it should render with 100 which i passed in alwaysOpen
You are not missing anything, I just didn't test this case. It might be tricky to handle both cases together, I will try to look at it when I'm done with my list.
When HeaderComponent is passed, this issue is still there. You should either remove the HeaderComponent prop or the adjustToContentHeight prop to make the alwaysOpen prop work.
Activity
jeremybarbet commentedon Apr 12, 2020
Hi,
You are not missing anything, I just didn't test this case. It might be tricky to handle both cases together, I will try to look at it when I'm done with my list.
fix: alwaysOpen and ajustToContentHeight #172
jeremybarbet commentedon Apr 25, 2020
Fixed and release in
rc-25
ydv0121 commentedon Apr 25, 2020
Damn you are flash🤘😅.
will try it.
Thank you man
ydv0121 commentedon Apr 27, 2020
Hello @jeremybarbet
i am getting still same issue in
rc-25
Modalize open default with
adjustToContentHeight
when using withalwaysOpen
My
react-native
version is 0.58.4jeremybarbet commentedon Apr 28, 2020
https://b.ueno.is/WnuGlBAQ
Is that not what you were talking about? that adjustToContentHeight wasn't working while being used along with alwaysOpen props?
ydv0121 commentedon Apr 30, 2020
its working now..issue with my node_modules or what i don't know but i reinstall the lib and its working now perfectly. Thank you man..Thanks
jeremybarbet commentedon Apr 30, 2020
Sweet, good to hear!
eladgel commentedon Apr 27, 2021
@jeremybarbet There is an issue when you add HeaderComponent in this scenario where the action sheet doesn't open at all...
nirajniroula commentedon Nov 9, 2021
When
HeaderComponent
is passed, this issue is still there. You should either remove theHeaderComponent
prop or theadjustToContentHeight
prop to make thealwaysOpen
prop work.