fix: check to ensure forbid-prop-types throws only off of React.PropTypes #2739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Aug 3, 2020
An issue was raised where using an alternative library with a similar syntax (in this case Yup) resulted in the rule `forbid-prop-types` stating that `Yup.array()` was an invalid proptype. Adding another check to ensure pragma is used and the check is off of `PropTypes`, removes the false erorrs thrown up when using those other libraries. Signed-off-by: Josh Kelly <josh@codecog.dev>
nonewcode
changed the title
PropTypesPropTypes
nonewcode
changed the title
PropTypes
ljharb
requested changes
Aug 9, 2020
| @@ -170,6 +172,7 @@ module.exports = { | |||
| CallExpression(node) { | |||
| if ( | |||
| node.arguments.length > 0 | |||
| && `${pragma}.PropTypes` | |||
There was a problem hiding this comment.
should this be comparing this string to anything? otherwise it's just a noop and could be deleted.
Suggested change
| && `${pragma}.PropTypes` | |
| && node.callee.object.name === `${pragma}.PropTypes` |
|
@nonewcode are you still interested in completing this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was raised where using an alternative library with a similar syntax (in this case Yup) resulted in the rule
forbid-prop-typesstating thatYup.array()was an invalid proptype. Adding another check to ensure pragma is used and the check is off ofPropTypes, removes the false erorrs thrown up when using those other libraries.