Skip to content

feat: drop Node 4, 6, 8, 10, 12, 14 & 16 support #3845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
"node": true
},
"parserOptions": {
"ecmaVersion": 6,
"ecmaVersion": 2022,
"ecmaFeatures": {
"jsx": true
},
@@ -34,17 +34,10 @@
"consistent-return": 0,

"prefer-destructuring": [2, { "array": false, "object": false }, { "enforceForRenamedProperties": false }],
"prefer-object-spread": 0, // until node 8 is required
"prefer-rest-params": 0, // until node 6 is required
"prefer-spread": 0, // until node 6 is required
"function-call-argument-newline": 1, // TODO: enable
"function-call-argument-newline": 1,
"function-paren-newline": 0,
"no-plusplus": [2, {"allowForLoopAfterthoughts": true}],
"no-param-reassign": 1,
"no-restricted-syntax": [2, {
"selector": "ObjectPattern",
"message": "Object destructuring is not compatible with Node v4"
}],
"strict": [2, "safe"],
"valid-jsdoc": [2, {
"requireReturn": false,
@@ -73,12 +66,11 @@
{
"files": ".github/workflows/*.js",
"parserOptions": {
"ecmaVersion": 2019,
"ecmaVersion": 2022,
},
"rules": {
"camelcase": 0,
"no-console": 0,
"no-restricted-syntax": 0,
},
},
],
117 changes: 0 additions & 117 deletions .github/workflows/node-minors.yml

This file was deleted.

4 changes: 2 additions & 2 deletions .github/workflows/node-18+.yml → .github/workflows/node.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: 'Tests: node.js (18+)'
name: 'Tests: node.js'

on: [pull_request, push]

@@ -14,7 +14,7 @@ jobs:
with:
versionsAsRoot: true
type: majors
preset: '>=18'
preset: '^18.18.0 || ^20.9.0 || >=21.1.0'

latest:
needs: [matrix]
12 changes: 6 additions & 6 deletions lib/rules/boolean-prop-naming.js
Original file line number Diff line number Diff line change
@@ -260,7 +260,7 @@ module.exports = {
}

const annotationTypeArguments = propsUtil.getTypeArguments(
component.node.parent.id.typeAnnotation.typeAnnotation
component.node.parent.id.typeAnnotation.typeAnnotation,
);
if (
annotationTypeArguments && (
@@ -269,7 +269,7 @@ module.exports = {
)
) {
return annotationTypeArguments.params.find(
(param) => param.type === 'TSTypeReference' || param.type === 'GenericTypeAnnotation'
(param) => param.type === 'TSTypeReference' || param.type === 'GenericTypeAnnotation',
);
}
}
@@ -278,7 +278,7 @@ module.exports = {
if (node.type === 'TSTypeLiteral' || node.type === 'ObjectTypeAnnotation' || node.type === 'TSInterfaceBody') {
const currentNode = [].concat(
objectTypeAnnotations.get(identifier.name) || [],
node
node,
);
objectTypeAnnotations.set(identifier.name, currentNode);
} else if (
@@ -317,7 +317,7 @@ module.exports = {
&& astUtil.isCallExpression(node.value)
&& propWrapperUtil.isPropWrapperFunction(
context,
getText(context, node.value.callee)
getText(context, node.value.callee),
)
) {
checkPropWrapperArguments(node, node.value.arguments);
@@ -343,7 +343,7 @@ module.exports = {
astUtil.isCallExpression(right)
&& propWrapperUtil.isPropWrapperFunction(
context,
getText(context, right.callee)
getText(context, right.callee),
)
) {
checkPropWrapperArguments(component.node, right.arguments);
@@ -407,7 +407,7 @@ module.exports = {
[].concat(propType).filter(Boolean).forEach((prop) => {
validatePropNaming(
component.node,
prop.properties || prop.members || prop.body
prop.properties || prop.members || prop.body,
);
});
}
2 changes: 1 addition & 1 deletion lib/rules/button-has-type.js
Original file line number Diff line number Diff line change
@@ -61,7 +61,7 @@ module.exports = {
},

create(context) {
const configuration = Object.assign({}, optionDefaults, context.options[0]);
const configuration = { ...optionDefaults, ...context.options[0] };

function reportMissing(node) {
report(context, messages.missingType, 'missingType', {
10 changes: 5 additions & 5 deletions lib/rules/checked-requires-onchange-or-readonly.js
Original file line number Diff line number Diff line change
@@ -36,8 +36,8 @@ function extractTargetProps(properties, keyName) {
prop[keyName] && targetPropSet.has(prop[keyName].name)
? [prop[keyName].name]
: []
)
)
),
),
);
}

@@ -64,14 +64,14 @@ module.exports = {
}],
},
create(context) {
const options = Object.assign({}, defaultOptions, context.options[0]);
const options = { ...defaultOptions, ...context.options[0] };

function reportMissingProperty(node) {
report(
context,
messages.missingProperty,
'missingProperty',
{ node }
{ node },
);
}

@@ -80,7 +80,7 @@ module.exports = {
context,
messages.exclusiveCheckedAttribute,
'exclusiveCheckedAttribute',
{ node }
{ node },
);
}

2 changes: 1 addition & 1 deletion lib/rules/default-props-match-prop-types.js
Original file line number Diff line number Diff line change
@@ -100,7 +100,7 @@ module.exports = {
.forEach((component) => {
reportInvalidDefaultProps(
component.declaredPropTypes,
component.defaultProps || {}
component.defaultProps || {},
);
});
},
2 changes: 1 addition & 1 deletion lib/rules/display-name.js
Original file line number Diff line number Diff line change
@@ -276,7 +276,7 @@ module.exports = {
// Report missing display name for all context objects
forEach(
filter(contextObjects.values(), (v) => !v.hasDisplayName),
(contextObj) => reportMissingContextDisplayName(contextObj)
(contextObj) => reportMissingContextDisplayName(contextObj),
);
}
},
4 changes: 2 additions & 2 deletions lib/rules/forbid-component-props.js
Original file line number Diff line number Diff line change
@@ -179,7 +179,7 @@ module.exports = {
}

return options.allowPatternList.every(
(pattern) => !minimatch(tagName, pattern)
(pattern) => !minimatch(tagName, pattern),
);
}

@@ -193,7 +193,7 @@ module.exports = {
}

return options.disallowPatternList.some(
(pattern) => minimatch(tagName, pattern)
(pattern) => minimatch(tagName, pattern),
);
}

2 changes: 1 addition & 1 deletion lib/rules/forbid-elements.js
Original file line number Diff line number Diff line change
@@ -86,7 +86,7 @@ module.exports = {
element,
message,
},
}
},
);
}
}
6 changes: 3 additions & 3 deletions lib/rules/forward-ref-uses-ref.js
Original file line number Diff line number Diff line change
@@ -78,18 +78,18 @@ module.exports = {
const shouldAddParentheses = node.type === 'ArrowFunctionExpression' && !isParenthesized(context, param);
return [].concat(
shouldAddParentheses ? fixer.insertTextBefore(param, '(') : [],
fixer.insertTextAfter(param, `, ref${shouldAddParentheses ? ')' : ''}`)
fixer.insertTextAfter(param, `, ref${shouldAddParentheses ? ')' : ''}`),
);
},
}
},
),
Object.assign(
getMessageData('removeForwardRef', messages.removeForwardRef),
{
fix(fixer) {
return fixer.replaceText(node.parent, sourceCode.getText(node));
},
}
},
),
],
});
10 changes: 5 additions & 5 deletions lib/rules/function-component-definition.js
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@ const propsUtil = require('../util/props');
function buildFunction(template, parts) {
return Object.keys(parts).reduce(
(acc, key) => acc.replace(`{${key}}`, () => parts[key] || ''),
template
template,
);
}

@@ -72,7 +72,7 @@ function getParams(node, source) {
if (node.params.length === 0) return null;
return source.slice(
node.params[0].range[0],
node.params[node.params.length - 1].range[1]
node.params[node.params.length - 1].range[1],
);
}

@@ -176,10 +176,10 @@ module.exports = {
let fileVarType = 'var';

const namedConfig = [].concat(
configuration.namedComponents || 'function-declaration'
configuration.namedComponents || 'function-declaration',
);
const unnamedConfig = [].concat(
configuration.unnamedComponents || 'function-expression'
configuration.unnamedComponents || 'function-expression',
);

function getFixer(node, options) {
@@ -214,7 +214,7 @@ module.exports = {
body: getBody(node, source),
name: getName(node),
varType,
})
}),
);
}

Loading
Oops, something went wrong.
Loading
Oops, something went wrong.