Skip to content

Fix content type for bitcoin request #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

Jtramey
Copy link

@Jtramey Jtramey commented Jan 21, 2024

Hey should fix:
#97

@@ -264,8 +264,8 @@ async def bitcoin(self, context: Context) -> None:
) as request:
if request.status == 200:
data = await request.json(
content_type="application/javascript"
) # For some reason the returned content is of type JavaScript
content_type="application/json"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it makes more sense to just remove it, as default is that content type header.

@kkrypt0nn kkrypt0nn self-assigned this Jan 29, 2024
@kkrypt0nn kkrypt0nn added bug Something isn't working priority: medium This has a medium priority labels Jan 29, 2024
@kkrypt0nn
Copy link
Owner

Any updates on this @Jtramey ?

@kkrypt0nn kkrypt0nn added the waiting for author Waiting for a reply from the author to further investigate label May 12, 2024
@kkrypt0nn
Copy link
Owner

kkrypt0nn commented Jul 21, 2024

Solved as per v6.2.0

@kkrypt0nn kkrypt0nn closed this Jul 21, 2024
@kkrypt0nn kkrypt0nn removed the waiting for author Waiting for a reply from the author to further investigate label Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: medium This has a medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants