Skip to content

RWKV #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 17, 2024
Merged

RWKV #222

merged 10 commits into from
Mar 17, 2024

Conversation

jahatef
Copy link
Contributor

@jahatef jahatef commented Nov 6, 2023

Here is an implementation of the RWKV code with annotations that I am completing with @Quentin-Anthony.
https://arxiv.org/abs/2305.13048

We have been unable to build all the docs due to our lack of access to pylit. Could you either take care of the docs creation or could you open source your internal version of pylit so that we can create them and make sure they are correctly formatted?

Also, we have not finished the training loop implementation in line 136 of labml_nn/RWKV/experiment.py.

@jahatef jahatef marked this pull request as draft November 6, 2023 04:55
@jahatef jahatef changed the title RWKV (draft) RWKV Nov 6, 2023
@vpj
Copy link
Member

vpj commented Nov 6, 2023

I will generate the HTML when you are ready.

Thanks for the contribution!

@jahatef
Copy link
Contributor Author

jahatef commented Mar 9, 2024

Alright this should be ready for review. Let us know if you need anything else here.

@jahatef jahatef marked this pull request as ready for review March 9, 2024 18:53
@vpj vpj merged commit 7db6e92 into labmlai:master Mar 17, 2024
@vpj
Copy link
Member

vpj commented Mar 17, 2024

Sorry for the delay; I've been busy with work. I generated documentations and changed formatting a little.

The generated docs are here: https://nn.labml.ai/RWKV/

I feel a a little more comments will help? Let me know what you think and we can link it from the home page once it's ready.

Also, why do you have a custom LayerNorm implementation? Can we use Pytorch layernorm or the layernorm implemented here: https://nn.labml.ai/normalization/layer_norm/index.html

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants