Skip to content

Minor, uncontroversial changes #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 16, 2021
Merged

Conversation

SWinxy
Copy link
Contributor

@SWinxy SWinxy commented Mar 15, 2021

I've made some changes that I hope you have no objections to. Here's a list of those changes:

  • Instance.java no longer calls vkEnumerateInstanceLayerProperties() with an integer array, instead now with an IntBuffer.
  • Window class doesn't need to implement GLFWFramebufferSizeCallbackI, since the invoke() method would never have been called anyway.
  • Reworked getting instance layer names to something a little more readable. Rather than using arrays of arrays, check if the layer is present, and return that.
  • Sorted fields in a consistent manner (static final, then final, then mutable). IDEA shouldn't interfere with them.
  • Inlined the return of createDebugCallBack().

Lmk what you think.

@lwjglgamedev
Copy link
Owner

Thanks ! Amazing work.

At a first look it seems good to me. Please, let me review the changes and I will integrate the changes. (I mayneed some days. Too much work this week). I will not make any more code modifications until this is merged.

Thanks again.

@SWinxy
Copy link
Contributor Author

SWinxy commented Mar 15, 2021

No worries. Take your time.

@lwjglgamedev lwjglgamedev merged commit 53c6618 into lwjglgamedev:master Mar 16, 2021
@SWinxy
Copy link
Contributor Author

SWinxy commented Mar 16, 2021

Awesome. You're not going to like the next PR I have in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants