Skip to content

Received Slack payloads are not processed properly #1548

@omid-jf

Description

@omid-jf

Version

v4.11.0

Describe the bug

When content received from Slack is in type application/x-www-form-urlencoded, a dictionary called request_dict is created from the body using the query_string_to_dictionary method of the SlackHelper class. The resulting dictionary has one key called payload and its value is a dictionary with several key-values ({"type": ..., "user": ..., etc.}).
Later, a SlackPayload object is created from the key-values. However, the constructor of the SlackPayload class gets the values of the nested dictionary without getting the value of first key. Therefore, everything turns to be None in that object.

To Reproduce

  1. Use the 60.slack-adapter sample.
  2. Put a breakpoint in line 11 of botbuilder/adapters/slack/slack_payload.py and start debugging.
  3. Use the /test command in Slack (requires registering the command in the Slack application).
  4. In Slack, click on of the buttons sent from the bot.

Expected behavior

The created SlackPayload object should contain information about the Slack action.

Screenshots

ms_bot_bug

Activity

added
bugIndicates an unexpected problem or an unintended behavior.
needs-triageThe issue has just been created and it has not been reviewed by the team.
on Feb 21, 2021
omid-jf

omid-jf commented on Feb 21, 2021

@omid-jf
Author

Another related bug:

Line 29 of the same file (slack_payload.py) has an incorrect syntax (check the screenshot below).
if isinstance(message) is SlackMessage
should be changed to:
if isinstance(message, SlackMessage)

ms_bot_bug2

added
Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.
customer-reportedIssue is created by anyone that is not a collaborator in the repository.
on Feb 22, 2021
removed
needs-triageThe issue has just been created and it has not been reviewed by the team.
on Feb 22, 2021
congysu

congysu commented on Feb 23, 2021

@congysu
Member

Thanks @axelsrz to take a look at this item.

congysu

congysu commented on Feb 25, 2021

@congysu
Member

@axelsrz could you please take a look at this one? Thanks.

axelsrz

axelsrz commented on Feb 25, 2021

@axelsrz
Member

bringing @tracyboehrer into the loop

added this to the r13 milestone on Mar 3, 2021
tracyboehrer

tracyboehrer commented on Mar 3, 2021

@tracyboehrer
Member

@omid-jf Thanks for reporting this. I'll get setup to test and correct this, and get it into the next release.

2 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.bugIndicates an unexpected problem or an unintended behavior.customer-reportedIssue is created by anyone that is not a collaborator in the repository.

Type

No type

Projects

No projects

Relationships

None yet

    Participants

    @tracyboehrer@omid-jf@axelsrz@congysu@stevkan

    Issue actions

      Received Slack payloads are not processed properly · Issue #1548 · microsoft/botbuilder-python