Skip to content

Add clarification on log package for logging #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

rogiervandenberg
Copy link
Contributor

As the target audience for your overview (proficient in node, but beginner in Go) I was delighted to see all the examples. But I stumbled on an error, or so I thought 🙈

As the Logging example was omitting the timestamp in the code (as is part of the node example), I wanted to 'fix' that Logging Go example with:

fmt.Println(time.Now().Format(time.RFC3339), "hello world")

..only to find out that the log package already automagically includes the timestamp! 🎉 😮

For people moving from node to Go this is totally not obvious, so I thought it is very nice to explain that to prevent others from making the same assumption.

@miguelmota
Copy link
Owner

@rogiervandenberg Good suggestion!

Changes look good. Merging.

Thanks!

@miguelmota miguelmota merged commit 7f3fee7 into miguelmota:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants