Skip to content

Cannot access Discourse if user have changed username / email associated to their edx account #32

@brospars

Description

@brospars

If an user changes his username or email associated with their edx account, then he cannot access Discourse because of this.

Wouldn't it be possible to update his account instead of throwing an error ?

Activity

kevinrobinson

kevinrobinson commented on May 7, 2019

@kevinrobinson
Contributor

@brospars Thanks! In my limited experience, this hasn't been an issue, so that's why it's more conservative now. But that may be related to the particular courses, or that they've been smaller and we just haven't run into anyone changing their name yet. :)

If you want to submit a pull request changing this, please include links to EdX documentation and Discourse docs about this, as the plugin would have to make the same assumptions about which is the primary key and how changes are handled (eg, as in https://support.edx.org/hc/en-us/articles/115016004448-Can-I-change-my-edX-username- for EdX).

brospars

brospars commented on May 7, 2019

@brospars
Author

Yes Edx use the username as primary key, so this plugin could make the same assumption and if the email has changed then update it.

I'm leaving for some days but I will look into it next week

kevinrobinson

kevinrobinson commented on May 7, 2019

@kevinrobinson
Contributor

@brospars Sounds good, pull requests welcome! 👍

I'm also happy to brainstorm on how to verify this is works correctly for the various edge cases, since there's a bunch of risk in deploying that I likely won't be able to verify myself.

linked a pull request that will close this issue on Apr 26, 2021
brospars

brospars commented on Jun 30, 2021

@brospars
Author

@kevinrobinson Hello just to let you know I've opened two PR would you mind taking a look ?

added a commit that references this issue on Nov 29, 2021
110c1a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @kevinrobinson@brospars

      Issue actions

        Cannot access Discourse if user have changed username / email associated to their edx account · Issue #32 · mit-teaching-systems-lab/discourse-edx-lti