Skip to content

Show session id per request in simpleStreamableHttp example server #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cliffhall
Copy link
Contributor

@cliffhall cliffhall commented Jun 16, 2025

  • In src/examples/server/simpleStreamableHttp.ts
    • In mcpPostHandler,
      • Get mcp-session-id header early so that it can be reported in every incoming request.
      • Helpful for troubleshooting Inspector's ability to retain the session id for the Proxy <-> Server leg
    • Linter fixed a few small whitespace foibles.

Motivation and Context

  • A recent issue in the Inspector repo questioned the its proxy's ability to retain and send the appropriate mcp-session-id header to the server.
  • In order to demonstrate that each request following the initialize request carried this header with the appropriate id.
  • This is a go-to, in-project server that we frequently test simple streamable connections as well as OAuth.
  • The only problem was that this server did not report the session id for each incoming request, because it did not extract the header before reporting the request and its contents.
  • This change simply gets the header as soon as the request comes in and if the sessionId is present, it includes it in its log output.

How Has This Been Tested?

Breaking Changes

Nope.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

  - In  mcpPostHandler,
    - Get `mcp-session-id` header early so that it can be reported in every incoming request.
    - Helpful for troubleshooting Inspector's ability to retain the session id for the Proxy <-> Server leg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant