Include supported scopes in authorization url #648
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope parameter missing in oauth authorize endpoint when using the quick oauth flow in MCP Inspector.
Motivation and Context
modelcontextprotocol/inspector#465
In the MCP Inspector, during guided oauth flow, a correct auth url is formed which includes scope parameter. This behavior is achieved by this line. It makes sense to have the same logic in SDK.
How Has This Been Tested?
Suggested change has been executed in DevTools, and authentication was successful.
Breaking Changes
Possible breaking changes - previously if scope hasn't been provided, a fallback would be clientMetadata's
scope
. Now the first fallback is metadata'ssupported_scopes
.Types of changes
Checklist
Additional context
The "should read messages" test is not passing locally on this branch, however it doesn't pass on main as well. All other tests are passing.