Improve Netty test variants #1721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the Netty test variants by ensuring that unified reactive tests use the Netty configuration for increased coverage and by streamlining async transport settings across test suites. Key changes include:
- Modifying UnifiedReactiveStreamsTest to override MongoClientSettings with custom TransportSettings.
- Removing duplicate client creation logic from ClientSideOperationTimeoutTest.
- Updating ClusterFixture and Evergreen configuration to use the new ASYNC_TRANSPORT property.
- Adjusting .evergreen run-tests scripts and matrix configurations accordingly.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| driver-reactive-streams/src/test/functional/com/mongodb/reactivestreams/client/unified/UnifiedReactiveStreamsTest.java | Applies overridden TransportSettings when present. |
| driver-reactive-streams/src/test/functional/com/mongodb/reactivestreams/client/unified/ClientSideOperationTimeoutTest.java | Removes the custom createMongoClient override. |
| driver-core/src/test/functional/com/mongodb/ClusterFixture.java | Updates property retrieval to use "org.mongodb.test.async.transport". |
| .evergreen/run-tests.sh | Adjusts environment variable usage from STREAM_TYPE to ASYNC_TRANSPORT. |
| .evergreen/.evg.yml | Updates matrix specs and tasks to reflect the new async transport settings. |
Comments suppressed due to low confidence (1)
driver-core/src/test/functional/com/mongodb/ClusterFixture.java:523
- [nitpick] Consider renaming 'asyncTransport' to 'asyncTransportType' to clarify that the variable represents a transport type configuration.
String asyncTransport = System.getProperty("org.mongodb.test.async.transport", "nio2");
jyemin
commented
May 29, 2025
.evergreen/.evg.yml
Outdated
| display_name: "Netty SSL provider: ${version} ${topology} ${ssl} SslProvider.${netty-ssl-provider} ${auth} ${jdk} ${os} " | ||
| tags: ["tests-netty-variant"] | ||
| tasks: | ||
| - name: "netty-test" | ||
| - name: "test-reactive" |
There was a problem hiding this comment.
Spilt into the two tasks to make it run faster, as has already been done for the main test matrix. Core and reactive are the only two modules that pay attention to the transport settings.
| # MONGODB_URI Set the suggested connection MONGODB_URI (including credentials and topology info) | ||
| # TOPOLOGY Allows you to modify variables and the MONGODB_URI based on test topology | ||
| # Supported values: "server", "replica_set", "sharded_cluster" | ||
| # COMPRESSOR Set to enable compression. Values are "snappy" and "zlib" (default is no compression) | ||
| # STREAM_TYPE Set the stream type. Values are "nio2" or "netty". Defaults to "nio2". | ||
| # ASYNC_TRANSPORT Set the async transport. Values are "nio2" or "netty". |
There was a problem hiding this comment.
Changed the name to match the new TransportSettings class introduced in 5.0
| @@ -34,13 +34,14 @@ SSL=${SSL:-nossl} | |||
| MONGODB_URI=${MONGODB_URI:-} | |||
| TOPOLOGY=${TOPOLOGY:-server} | |||
| COMPRESSOR=${COMPRESSOR:-} | |||
| STREAM_TYPE=${STREAM_TYPE:-nio2} | |||
There was a problem hiding this comment.
No need to default it since it's already defaulted in ClusterFixture
...st/functional/com/mongodb/reactivestreams/client/unified/ClientSideOperationTimeoutTest.java
Show resolved
Hide resolved
|
@rozza do you want me to hold off on merging this? |
* Only run driver-core and driver-reactive-streams test suites, each in its own task (as we do in other variants). * Use Netty configuration in all unified reactive tests, increasing coverage of Netty in driver-reactive-streams JAVA-5887
rozza
requested changes
Jun 17, 2025
Co-authored-by: Ross Lawley <ross.lawley@gmail.com>
* Add space between '"' and ']''. Otherwise, it silently fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-5887