Add CSOT to OIDC. #1741
Merged
Add CSOT to OIDC. #1741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAVA-5357
rozza
requested changes
Jun 17, 2025
driver-core/src/main/com/mongodb/internal/connection/SaslAuthenticator.java
Outdated
Show resolved
Hide resolved
| if (timeoutContext.hasTimeoutMS()) { | ||
| return assertNotNull(timeoutContext.getTimeout()).call(TimeUnit.MILLISECONDS, | ||
| () -> { | ||
| Assertions.fail(); |
There was a problem hiding this comment.
From the tests it looks like it should fall back to serverSelectionTimeoutMS - if theres an infinite timeout - so how does that logic work?
Also it might be best to put an assertion message incase a future regression means this code path is hit - potentially would make debugging it easier.
There was a problem hiding this comment.
I initially assumed, based on the spec, that serverSelectionTimeoutMS couldn’t be infinite, so I added the assertion. However, our implementation allows infinite timeouts for serverSelectionTimeoutMS. Given this, i see two options:
- If both
timeoutMsandserverSelectionTimeoutMSare infinite, throw an exception. - The OIDC spec doesn’t specify behavior for infinite timeouts, but we could pass the maximum
Durationvalue (usingChronoUnit.FOREVER.getDuration()) to the OIDC callback. While not technically infinite, it’s large enough to represent an infinite timeout, aligning with both the OIDC spec (as it is technicallyLong.MAX_VALUEand not infinite) and our current API for infiniteserverSelectionTimeoutMS.
I think option 2 is preferable, so I’ve added it in this commit: cc5469d. Let me know your thoughts.
…nticator.java Co-authored-by: Ross Lawley <ross.lawley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
The correct ticket for this PR is JAVA-5337.
Ticket JAVA-5357 was incorrectly linked.