PYTHON-5344 and PYTHON-5403 Allow Instantiated MongoClients to Send Client Metadata On-Demand #2358
+617
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
blink1073
reviewed
Jun 5, 2025
pymongo/asynchronous/mongo_client.py
Outdated
| @@ -1040,6 +1041,20 @@ async def target() -> bool: | |||
| self._kill_cursors_executor = executor | |||
| self._opened = False | |||
|
|
|||
| def _append_metadata(self, driver_info: DriverInfo) -> None: | |||
There was a problem hiding this comment.
I think this needs to be public: "Specifies that drivers MUST provide an API to allow updating client metadata (name, version, platform) after initialization"
sleepyStick
changed the title
sleepyStick
changed the title
blink1073
requested changes
Jun 18, 2025
| ) | ||
|
|
||
| # Generate unified tests. | ||
| globals().update(generate_test_classes(_TEST_PATH, module=__name__, RUN_ON_SERVERLESS=True)) |
There was a problem hiding this comment.
We don't test on serverless anymore, so you can remove RUN_ON_SERVERLESS.
| @@ -703,6 +704,7 @@ async def _collectionOperation_createChangeStream(self, target, *args, **kwargs) | |||
| async def _databaseOperation_runCommand(self, target, **kwargs): | |||
| self.__raise_if_unsupported("runCommand", target, AsyncDatabase) | |||
| # Ensure the first key is the command name. | |||
| print(kwargs) | |||
There was a problem hiding this comment.
there's several print statements left in this file
| ) -> None: | ||
| # send initial metadata | ||
| name, version, platform, metadata = await self.send_ping_and_get_metadata(client, True) | ||
| await asyncio.sleep(0.005) |
There was a problem hiding this comment.
Why this specific sleep? Is this a potential source of flakiness?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PYTHON-5344
https://jira.mongodb.org/browse/PYTHON-5403 (ticket for async tests)
Notes:
test/mockupdb) to utilize synchro for the async -> sync tests.