Nominating dario-piotrowicz as a collaborator

[jasnell]

Dario is a colleague of myself and @anonrig at Cloudflare. They have been working with and have been onboarded onto the @nodejs/nodejs-website team and have been actively contributing to nodejs/node for the past few months. They would make a great candidate for node.js collaborator.

• Commits authored on nodejs/node: github.com/nodejs/node/commits?author=dario-piotrowicz
• Pull requests opened: github.com/search?q=author:dario-piotrowicz+org:nodejs&type=pullrequests
• Issues opened: github.com/search?q=author:dario-piotrowicz+org:nodejs&type=issues
• Comments on pull requests and issues throughout the Node.js organization: github.com/search?q=commenter%3Adario-piotrowicz+org%3Anodejs&type=pullrequests

cc @nodejs/collaborators @nodejs/tsc @dario-piotrowicz

[avivkeller]

Speaking as a member of @nodejs/nodejs-website, @dario-piotrowicz has been an amazing addition to our team, and we've all had a great experience working with them!

[RaisinTen]

Definitely +1!

[UlisesGascon]

Huge +1!

[marco-ippolito]

+1

[mcollina]

+1

[mhdawson]

+1 from me

[ovflowd]

I wish I could give a +1 but I'm not a collaborator anymore. But if I could, definitely a huge +1 <3

[juanarbol]

+1 from me

[anonrig]

It's been more than seven days, which means this nomination has passed, congrats! @dario-piotrowicz can you confirm publicly that you're interested? If so, let's schedule an onboarding.

[dario-piotrowicz]

Hey @anonrig, thank you very much! 😄

Yes, I'm definitely interested! Let's schedule an onboarding 😄

Also I would really like to thank @jasnell a lot for the nomination and thanks a lot also for everyone's support and trust, I'm really looking forward to it and I'll do my very best to earn my place as collaborator 🫶

[anonrig]

Happ to hear that! I'll schedule a call with @dario-piotrowicz.

[RaisinTen]

#58102 has landed, so I'm closing this. Welcome Dario! :)

[dario-piotrowicz]

Thanks @RaisinTen 😄 🫶

However I added Fixes https://github.com/nodejs/node/issues/57983 in #58102 so shouldn't this issue have been closed automatically? 🤔

[anonrig]

It should have been?

[RaisinTen]

The GitHub PR description does have the Fixes link but it was closed and the commit that landed on main c240c03 does not have the Fixes link, so that's why this didn't get auto-closed

[dario-piotrowicz]

mh.... is this expected? or did I mess up the PR landing? 🤔 (the fixes link was definitely present in the PR description as we were going through the landing process)

[targos]

We expect the "Fixes" line to be a valid commit trailer, so it should have a colon: Fixes: https://github.com... to be picked up by the git node land command.

[dario-piotrowicz]

Ah ok I see, thanks a bunch for the clarification @targos 🙂