Skip to content

size is unused in OutgoingMessage.prototype._writeRaw #57985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mhart opened this issue Apr 23, 2025 · 0 comments
Open

size is unused in OutgoingMessage.prototype._writeRaw #57985

mhart opened this issue Apr 23, 2025 · 0 comments

Comments

@mhart
Copy link
Contributor

mhart commented Apr 23, 2025 •
edited
Loading

Observe that the size argument is unused in OutgoingMessage.prototype._writeRaw.

This also means that the byteLength argument is unused in OutgoingMessage.prototype._send – even though it's specified in a number of places.

Introduced in #46601 but weirdly it was unused in that commit too (perhaps lost during review?)

I worry that a bug was introduced – but if it truly should be unused, can it be removed?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhart