Skip to content

Make util.isArray() EOL #58013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Renegade334 opened this issue Apr 24, 2025 · 6 comments
Open

Make util.isArray() EOL #58013

Renegade334 opened this issue Apr 24, 2025 · 6 comments

Comments

@Renegade334
Copy link
Contributor

util.isArray() was the sole util.is* type-checking method left over from #52744. The remainder are all EOL as of v23.0.0.

It looks like the motivation for leaving this at the time was to allow for its use to be removed from the form-data library, which it has since been.

Is there another motivation for leaving this as-is, or can it now be made EOL?

cc: @marco-ippolito

@anonrig
Copy link
Member

anonrig commented Apr 25, 2025

Can you open a pull-request?

@marco-ippolito
Copy link
Member

I remember there were other libraries affected, we need to run citgm

@miguelmarcondesf
Copy link
Contributor

I can take a look if you want to @Renegade334

@Renegade334
Copy link
Contributor Author

Renegade334 commented Apr 25, 2025

I can take a look if you want to

Sure, if you fancy.

Could also experiment with running citgm against removing util._extend(), as the other surviving graduate of #50488, although I suspect that legacy debug dependencies will still be an issue there.

@jasnell
Copy link
Member

jasnell commented Apr 25, 2025

This is one I'm less convinced that we can do. I still encounter a fair number of util.isArray(...) calls in third party dependencies.

@ljharb
Copy link
Member

ljharb commented Apr 25, 2025

fwiw if it's a small enough list, then like form-data, i could attempt to steward them and maximally backport a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants