Skip to content

test: add tests ensuring worker threads cannot access internals #58332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2025
Merged

test: add tests ensuring worker threads cannot access internals #58332

merged 2 commits into from
May 26, 2025

Conversation

Lordfirespeed
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 14, 2025
@Lordfirespeed Lordfirespeed mentioned this pull request May 14, 2025
Merged
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 14, 2025
@codecov Codecov
Copy link

codecov bot commented May 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (b197355) to head (775fe02).
Report is 111 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #58332   +/-   ##
=======================================
  Coverage   90.23%   90.23%           
=======================================
  Files         633      633           
  Lines      186818   186818           
  Branches    36668    36670    +2     
=======================================
+ Hits       168578   168579    +1     
- Misses      11036    11050   +14     
+ Partials     7204     7189   -15

see 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66797/

@Lordfirespeed
Copy link
Contributor Author

test failing is parallel.test-buffer-tostring-range on win11-COMPILED_BY-vs2022_clang with message Array buffer allocation failed - I don't think that's caused by the changes here?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66958/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66959/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66963/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66964/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67013/

@StefanStojanovic StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67014/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67022/

@StefanStojanovic
Copy link
Contributor

test failing is parallel.test-buffer-tostring-range on win11-COMPILED_BY-vs2022_clang with message Array buffer allocation failed - I don't think that's caused by the changes here?

Correct, this is not caused by changes here. I reran CI a few times until all platforms passed.

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 26, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 26, 2025
@nodejs-github-bot nodejs-github-bot merged commit e7255b6 into nodejs:main May 26, 2025
81 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e7255b6

@Lordfirespeed Lordfirespeed deleted the test-worker-internal-modules branch May 27, 2025 13:39
targos pushed a commit that referenced this pull request May 31, 2025
@Lordfirespeed @targos
test: add tests ensuring worker threads cannot access internals
beba631 
Refs: #57804 (comment)
Refs: #57804 (comment)
PR-URL: #58332
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
@github-actions github-actions bot mentioned this pull request Jun 8, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
@Lordfirespeed @aduh95
test: add tests ensuring worker threads cannot access internals
0137771 
Refs: #57804 (comment)
Refs: #57804 (comment)
PR-URL: #58332
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95

@dario-piotrowicz dario-piotrowicz

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lordfirespeed @nodejs-github-bot @StefanStojanovic @aduh95 @dario-piotrowicz