test: add chacha20-poly1305 to auth tag order test #58367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ChaCha20-Poly1305 to the algorithms for which we ensure that the authentication tag can be set either before or after calling `update()`.
tniessen
added
crypto
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58367 +/- ##
=======================================
Coverage 90.24% 90.24%
=======================================
Files 633 633
Lines 186859 186860 +1
Branches 36685 36685
=======================================
+ Hits 168622 168623 +1
+ Misses 11036 11033 -3
- Partials 7201 7204 +3 🚀 New features to boost your workflow:
|
lpinca
approved these changes
May 17, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
tniessen
added
the
author ready
panva
approved these changes
May 17, 2025
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1ef9923 |
targos
pushed a commit
that referenced
this pull request
May 31, 2025
Add ChaCha20-Poly1305 to the algorithms for which we ensure that the authentication tag can be set either before or after calling `update()`. PR-URL: #58367 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
Add ChaCha20-Poly1305 to the algorithms for which we ensure that the authentication tag can be set either before or after calling `update()`. PR-URL: #58367 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ChaCha20-Poly1305 to the algorithms for which we ensure that the authentication tag can be set either before or after calling
update().Change the key size to 256 bits for all algorithms so that we can use the same key across all three algorithms being tested.