Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nuxt-community/pwa-module
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: nuxt-community/pwa-module
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: feat/workbox-runtime
Choose a head ref
  • 13 commits
  • 5 files changed
  • 1 contributor

Commits on Aug 26, 2020

  1. Initial implementation of #336

    @Yihao-G
    Yihao-G committed Aug 26, 2020
    Copy the full SHA
    4dba893 View commit details

Commits on Aug 27, 2020

  1. Update types

    @Yihao-G
    Yihao-G committed Aug 27, 2020
    Copy the full SHA
    ad28d58 View commit details

  2. Fix test 

    The strategy constructor option object can be optional as shown here: https://developers.google.com/web/tools/workbox/modules/workbox-strategies
    @Yihao-G
    Yihao-G committed Aug 27, 2020
    Copy the full SHA
    e0af8c0 View commit details

  3. Fix broken generated sw.js

    @Yihao-G
    Yihao-G committed Aug 27, 2020
    Copy the full SHA
    f6e379c View commit details

  4. Remove unused field

    @Yihao-G
    Yihao-G committed Aug 27, 2020
    Copy the full SHA
    44b7c41 View commit details

  5. Typo fixes

    @Yihao-G
    Yihao-G committed Aug 27, 2020
    Copy the full SHA
    d581284 View commit details

  6. Correct RuntimeCaching type

    @Yihao-G
    Yihao-G committed Aug 27, 2020
    Copy the full SHA
    d728c9a View commit details

  7. Added tests

    @Yihao-G
    Yihao-G committed Aug 27, 2020
    Copy the full SHA
    d467e17 View commit details

  8. Fix code

    @Yihao-G
    Yihao-G committed Aug 27, 2020
    Copy the full SHA
    4cfdbd2 View commit details

  9. Revert "Added tests" partially 

    This reverts commit d467e17
    @Yihao-G
    Yihao-G committed Aug 27, 2020
    Copy the full SHA
    ab7748b View commit details

  10. Do not directly generate runtime code from nuxt.config 

    #337 (comment)
    @Yihao-G
    Yihao-G committed Aug 27, 2020
    Copy the full SHA
    5f84424 View commit details

Commits on Aug 28, 2020

  1. Template formatting and remove unnecessary replace in toCode function

    @Yihao-G
    Yihao-G committed Aug 28, 2020
    Copy the full SHA
    514f24d View commit details

  2. simplify toCode function

    @Yihao-G
    Yihao-G committed Aug 28, 2020
    Copy the full SHA
    0042aa9 View commit details

This comparison is taking too long to generate.

Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.

You can try running this command locally to see the comparison on your machine:
git diff main...feat/workbox-runtime