Skip to content

fix: skip update meta when instance is inactive #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: skip update meta when instance is inactive #716

wants to merge 1 commit into from
+3 −1

Conversation

Dante-dan
Copy link

Closes #715

@Dante-dan
Copy link
Author

e2e test need update chrome/selenium ?

@stale
Copy link

stale bot commented Apr 17, 2022

Thanks for your contribution to vue-meta! This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you would like this issue to remain open:

  1. Verify that you can still reproduce the issue in the latest version of vue-meta
  2. Comment the steps to reproduce it
    Issues that are labeled as pending will not be automatically marked as stale.

@stale stale bot added the stale label Apr 17, 2022
@stale stale bot closed this Apr 27, 2022
@Dante-dan
Copy link
Author

Dante-dan commented Jun 9, 2022 •
edited
Loading

@pimlie TBR 🙏 I need this Fix.

@Dante-dan
Copy link
Author

When I use <keep-alive> with <vue-router>, The inactived componet instance alive in memory, and it watcher will be working.

So, the inactived componnet will replace the meta by this.$watch('$metaInfo') .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue-meta will update unexpected information when I use <keep-alive>
1 participant
@Dante-dan