-
Notifications
You must be signed in to change notification settings - Fork 187
Open
Labels
bugSomething isn’t workingSomething isn’t working
Description
Encountered through trying to make a Plot.geo
choropleth that resembles the following:
Plot.plot({
marks: [
Plot.geo(countries, {
title: (d) =>
d.properties.user_data != 0
? `Fun property: ${d.properties.user_data}`
: null,
tip: true
})
]
})
The above snippet gives a title option that displays a geometry property when it is nonzero. Passing null
to the title option works as expected, which was to not display the tooltip for that geo feature.
However, in the case that user_data
is 0 for all features, Plot will throw the following error:
Uncaught TypeError: lines is null
g tip.js:160
each_default each.js:5
g tip.js:146
call_default call.js:4
g tip.js:145
call_default call.js:4
render tip.js:136
composeRender mark.js:147
render2 pointer.js:108
update pointer.js:99
pointermove pointer.js:161
The plot still renders properly and no tooltips are rendered, as desired.
I believe this is because Plot does not expect there to be 0 tool tips generated from the geo
title factory passed in.
Here's some more environment information:
- Browser: Observed on both Firefox and Chromium
- Using GeoJSON data (see
countries
above)
Metadata
Metadata
Assignees
Labels
bugSomething isn’t workingSomething isn’t working
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
[-]Uncaught TypeError when passing `null` to a mark's title[/-][+]Uncaught TypeError when passing `null` to all mark titles[/+]matthewCmatt commentedon Jan 30, 2025
I found a workaround for my usecase, which was to use a separate Mark for the tooltip. This prevents the error in the case that all features are filtered out:
matthewCmatt commentedon Jan 30, 2025
I've discovered the original solution (providing a
title
ofnull
) to a tooltip mark only works because of this error.When the mark renders the title of null, this error causes that tooltip to error out (see
Tip.render
intip.js
), causing nothing to be rendered. 😬Here's an MR to fix the error: #2275
For context, I used
tipGeoNoProjection
andtipGeoProjection
to reproduce this issue in the dev environment.Here's a feature request to allow the behavior I originally assumed Plot had: #2276