Skip to content
This repository was archived by the owner on Jun 13, 2023. It is now read-only.

Adding back in LiveQueryDemo-ObjC #238

Merged
merged 28 commits into from
Dec 17, 2020
Merged

Adding back in LiveQueryDemo-ObjC #238

merged 28 commits into from
Dec 17, 2020

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Nov 17, 2020

  • Removed LiveQueryDemo-ObjC run in circle by accident, adding back
  • Added watchOS to pod spec
  • Remove unnecessary bundle install in circle as it wastes time (leaves caching just in case it’s needed in the future)
  • Moved all builds from travis and circle to GitHub Actions (Xcode 12.2), except for Carthage which is Circle (Xcode 11.7)

@cbaker6 cbaker6 requested a review from a team November 17, 2020 18:57
@cbaker6 cbaker6 changed the base branch from master to main November 27, 2020 22:31
@cbaker6
Copy link
Contributor Author

cbaker6 commented Dec 15, 2020

@TomWFox can you replace travis in the branch protections with ci/cocoapods ci/docs? Also, you may need to copy the travis COCOAPODS_TRUNK_TOKEN to Github secrets.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Dec 16, 2020

@TomWFox I switched all tests to actions except for Carthage since it's a resource hog, that one can stay on circle. I'll do the same on the iOS SDK shortly

@TomWFox
Copy link
Contributor

TomWFox commented Dec 16, 2020

I just put a fresh token into GH secrets.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Dec 16, 2020

I updated the badges on here. One "ci" for the actions build on the main branch. The second "release" that shows the status of actions for "release" (pods and docs in the future in this repos case). The release one won't show properly until we try the first release via a tag.

@TomWFox what do you think about this? I've also done the same thing for the iOS SDK. Feel free to adjust if needed.

@TomWFox
Copy link
Contributor

TomWFox commented Dec 16, 2020

Sounds good to me!

@cbaker6 cbaker6 merged commit 684e481 into main Dec 17, 2020
@cbaker6 cbaker6 deleted the cbaker6-patch-1 branch December 17, 2020 02:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants