Skip to content

refactor: Remove ParseApp and tests #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Apr 27, 2023

New Pull Request Checklist

Issue Description

ParseApp was used in the old parse.com days and no longer works with open source parse server

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.59 🎉

Comparison is base (1dace2e) 97.88% compared to head (e4df55e) 98.47%.

❗ Current head e4df55e differs from pull request most recent head a1d343f. Consider uploading reports for the commit a1d343f to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #501      +/-   ##
============================================
+ Coverage     97.88%   98.47%   +0.59%     
+ Complexity     1066     1058       -8     
============================================
  Files            39       38       -1     
  Lines          3262     3213      -49     
============================================
- Hits           3193     3164      -29     
+ Misses           69       49      -20     
Impacted Files Coverage Δ
src/Parse/ParseCloud.php 100.00% <ø> (ø)
src/Parse/ParseFile.php 100.00% <ø> (ø)
src/Parse/ParsePush.php 100.00% <ø> (ø)
src/Parse/ParseClient.php 95.67% <100.00%> (-0.18%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dplewis dplewis requested a review from mtrezza April 28, 2023 01:13
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was ParseApp? Like an example app?

@dplewis
Copy link
Member Author

dplewis commented Apr 28, 2023

parse.dashboard.com/apps you can get the apps listed in your dashboard through the SDK

@mtrezza mtrezza merged commit 1eb1c3c into parse-community:master Apr 28, 2023
@parseplatformorg
Copy link

🎉 This change has been released in version 2.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version Edit label Apr 29, 2023
@dplewis dplewis deleted the remove-parseapp branch June 13, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version Edit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants