Skip to content

Parallelize loading included objects #7981

Open
@mtrezza

Description

@mtrezza
Member

New Feature / Enhancement Checklist

  • I am not disclosing a vulnerability.
    I am not just asking a question.
    I have searched through existing issues.

The following description was taken from @noahsilas who is the original author of the related (but stale) PR #6501.

Current Limitation

When preloading multiple fields, we can get some extra performance by doing multiple fetches simultaneously.

Feature / Enhancement Description

The solution here is to build what is basically a dependency graph out of promises; each include path blocks while it is waiting for whatever path it depends on to finish loading. Finally, once we have that graph, we return a promise that depends on every node in it.

Aside: Technically we only need to depend on leaf nodes, but there shouldn't be any meaningful difference between waiting on the leafs and waiting on the entire graph, and this way we don't have to do any analysis to find the leafs)

Example Use Case

Consider a query fetching comments, and requesting that ParseServer preload "post" and "author" pointers:

GET /classes/Comment?include=post,author

In this case, we first need to fetch the resulting "Comment" documents, but after that we should be able to fetch the documents referenced by the post and author fields of the results simultaneously, as they don't depend on each other at all.

Things get a little trickier when we have nested fields:

GET /classes/Comment?include=post,post.author,post.category

To resolve this query, we first need to fetch the related posts, and only once we've added the data about those posts into the results tree can we scan it for the post.author and post.category pointers. But, once that first fetch is completed, we can unblock both of those nested queries!

Alternatives / Workarounds

n/a

Activity

parse-github-assistant

parse-github-assistant commented on May 7, 2022

@parse-github-assistant

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!
added
type:featureNew feature or improvement of existing feature
on May 7, 2022
linked a pull request that will close this issueParallelize loading `include` objects #6501on May 7, 2022
added
bounty:$100Bounty applies for fixing this issue (Parse Bounty Program)
on May 7, 2022
changed the title [-]Parallelize loading include objects[/-] [+]Parallelize loading included objects[/+] on May 7, 2022
pinned this issue on May 7, 2022
Moumouls

Moumouls commented on May 8, 2022

@Moumouls
Member

This feature will also drastically improve GraphQL API. This PR is challenging and interesting to develop. I'll see one of my colleagues and I can dedicate a coding pair session to effectively address this issue in a readable manner.

The dependency graph is the right way to go.

unpinned this issue on Oct 12, 2022
Moumouls

Moumouls commented on Jan 12, 2025

@Moumouls
Member

@dblythy an update on the subject, if you are curious: #6501 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bounty:$100Bounty applies for fixing this issue (Parse Bounty Program)type:featureNew feature or improvement of existing feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @mtrezza@Moumouls

      Issue actions

        Parallelize loading included objects · Issue #7981 · parse-community/parse-server