fix: keycloak authentication not working #8259
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
mtrezza
commented
Oct 26, 2022
| Authorization: 'Bearer ' + access_token, | ||
| const { hostname, pathname, port, protocol } = new URL(config['auth-server-url']); | ||
|
|
||
| if ([hostname, pathname, port, protocol].some(each => !each)) |
There was a problem hiding this comment.
The !each looks odd, what do you want to validate here?
|
@mohamad-rai see comments above We also need a test for the auth adapter that shows that the issue is fixed. |
|
Keycloak adapter is completely broken. Any news on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
Related issue: #8243
Closes: #8243
Approach
TODOs before merging