Skip to content

Fixes in to_executorch for while #12062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes in to_executorch for while #12062

wants to merge 1 commit into from

Conversation

angelayi
Copy link
Contributor

Summary: Fixes while loop support in executorch AOT up until emitter (#8769 (comment))

Differential Revision: D77452951

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12062

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit d7b4344 with merge base b74c68d (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 27, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77452951

@angelayi angelayi mentioned this pull request Jun 27, 2025
Open
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

angelayi added a commit to angelayi/executorch-1 that referenced this pull request Jun 27, 2025
@angelayi @facebook-github-bot
Fixes in to_executorch for while (pytorch#12062)
68c6d89 
Summary:

Fixes while loop support in executorch AOT up until emitter (pytorch#8769 (comment))

Differential Revision: D77452951
@angelayi @facebook-github-bot
Fixes in to_executorch for while (pytorch#12062)
d7b4344 
Summary:
Pull Request resolved: pytorch#12062

Fixes while loop support in executorch AOT up until emitter (pytorch#8769 (comment))

Differential Revision: D77452951
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77452951

@JacobSzwejbka
Copy link
Contributor

Memory Planning didnt require any changes? Does it work with dynamic shape?

@angelayi
Copy link
Contributor Author

Memory Planning didnt require any changes? Does it work with dynamic shape?

My next error is in the emitter soo I guess memory planning doesn't require any changes? I didn't test for correctness though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angelayi @facebook-github-bot @JacobSzwejbka