fix for cocoa pod version #1452
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- lock starscream version to 4.0.04
Update Socket.IO-Client-Swift.podspec
|
Can you also change the ios deployment target? Not sure what it should be set to now |
|
not sure we should change anything but starscream |
|
@romaHerman See #1453. Would be nice if you could bump to 11.0 to reflect starscream |
- bumped iOS to 11.0 - bumped tvOS to 12.0 took version from https://github.com/daltoniam/Starscream/blob/master/Starscream.podspec
|
bumped iOS and tvOS versions |
|
@romaHerman I appreciate the changeset, but I went ahead and updated the library to support 4.0.6. Can you see if 16.1.0 release version works for you? (Be sure to clear any previous build data) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
locked Starscream to the 4.0.4