Skip to content

Create a cookie from a string #13680

Open
@while1618

Description

@while1618

Describe the problem

As discussed here #8564, when you call an external api which sets a cookie, it would be nice to just pass that cookie from the form action down to the client. Currently, you need to parse the cookie string with some custom parser or by adding set-cookie-parser dependency to your project, and then you can create the cookie with cookies.set().

It would be nice if you can just pass that cookie string to a method like cookies.setFromString(cookie).

Describe the proposed solution

Since svelte-kit already have set-cookie-parser dependency, it would be easy to just parse that string and call cookies.set() on extracted values.

I already created this, here is the PR #13681. So, does this feature request make sense? Will you consider merging?

P.S. my first PR here, so if I didn't follow every rule, pls forgive me.

Alternatives considered

No response

Importance

would make my life easier

Additional Information

No response

Activity

while1618

while1618 commented on Apr 9, 2025

@while1618
Author

Hey @eltigerchino, any update on this? Will you consider merging it? You need any changes in my PR?

eltigerchino

eltigerchino commented on Apr 10, 2025

@eltigerchino
Member

looks good to me but I'd wait for another maintainer to review it as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @while1618@eltigerchino

      Issue actions

        Create a cookie from a string · Issue #13680 · sveltejs/kit