-
-
Notifications
You must be signed in to change notification settings - Fork 116
feat: experimental rolldown-vite support #1135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+264
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94eb7e5
to
b74cd52
Compare
dominikg
commented
Jun 11, 2025
dominikg
commented
Jun 11, 2025
dominikg
commented
Jun 11, 2025
dominikg
commented
Jun 11, 2025
Loading status checks…
8ed9e8e
to
67ab5ea
Compare
dummdidumm
reviewed
Jun 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand what's going on but it looks mostly good to me
Loading status checks…
…ook info to drive filter
Loading status checks…
… by reference instead of using Object.assign
Loading status checks…
Loading status checks…
dummdidumm
approved these changes
Jun 13, 2025
Loading status checks…
…ns still referenced isScanner
Loading status checks…
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1117
the goal is that users can swap in npm:rolldown-vite for vite, vite-plugin-svelte detects it and it just works
optional: