Skip to content

[TRI-4123] Logging objects with keys with periods in doesn't render properly in the UI #1510

Open
@matt-aitken

Description

@matt-aitken
Member

Problem

{
  "Key 0.002mm": 31.4,
}

In our dashboard this appears as:

{
  "Key 0": {
      "002mm": 31.4
  }
}

We flatten them to store in the database using . as the delimiter. These dots will need to be escaped/unescaped when flattening/unflattening.

This won't impact anything except the logs, we only flatten data there. It'll work fine in payloads and outputs.

Flatten code: https://github.com/triggerdotdev/trigger.dev/blob/main/packages/core/src/v3/utils/flattenAttributes.ts
Flatten tests: https://github.com/triggerdotdev/trigger.dev/blob/main/packages/core/test/flattenAttributes.test.ts

TRI-4123

Activity

changed the title [-]Logging objects with keys with periods in doesn't render properly in the UI[/-] [+][TRI-4123] Logging objects with keys with periods in doesn't render properly in the UI[/+] on Nov 29, 2024
yadavshubham01

yadavshubham01 commented on Nov 29, 2024

@yadavshubham01
Contributor

hey @matt-aitken please review my PR #1514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @matt-aitken@yadavshubham01

      Issue actions

        [TRI-4123] Logging objects with keys with periods in doesn't render properly in the UI · Issue #1510 · triggerdotdev/trigger.dev