I was going to submit a PR to fix this, but then I saw these tests...

It seems that you can set the disallow_auth option to true and it will fail validation on an email.

Hi,

Thank you. I will try it. I would expect default behaviour with disallow_auth to true.

@ezkemboi can i work on this issue

@raghavbk if you have a PR, please do it and we will review it. Thanks.

@mjancarik
Buddy can you tell one thing

user@example.com : This will treated as an email due to the presence of " @ " in it , so I think its bound to return true to this

In no way is an email address a URL, as someone claimed in an issue.

mailto:xyz@xyz.net is a URL/URI, but xyz@xyz.net is not. This should be considered a bug.

Well, till someone figure out which way is the correct way, doing this works for everyone else:

validator.isURL('xyz@xyz.net', { disallow_auth: true }); // false

This is desired behaviour atm, see also #1753 (comment)
The option disallow_auth is provided for this usecase

The maintainers are obviously free to do what they want, but anyone arguing that user@example.com is a URL is flat-out wrong. It's not something subjective that's up for debate. I can cite evidence:

https://datatracker.ietf.org/doc/html/rfc3986#section-1.1.3

A URI can be further classified as a locator, a name, or both. The term "Uniform Resource Locator" (URL) refers to the subset of URIs that, in addition to identifying a resource, provide a means of locating the resource by describing its primary access mechanism (e.g., its network "location").

URI/URL examples: https://datatracker.ietf.org/doc/html/rfc3986#section-1.1.2

The RFC spec says "Each URI begins with a scheme name" and provides another clear example:

   The following are two example URIs and their component parts:

         foo://example.com:8042/over/there?name=ferret#nose
         \_/   \______________/\_________/ \_________/ \__/
          |           |            |            |        |
       scheme     authority       path        query   fragment
          |   _____________________|__
         / \ /                        \
         urn:example:animal:ferret:nose

Sorry to be pedantic, but if we're going to quote someone who claims that user@example.com is a URL "per spec," I think it needs to be called out.

I'm open to being challenged if someone can provide authoritative sources.

Thanks for the extensive response, I've reopened the issue so we can take another look at it

@WikiRik I appreciate being open to it! If there's no room for pedantry in engineering, then it ain't engineering. 😝