WIP RRGraphView node_is_wire() Implementation #2011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I have implemented
RRGraphView::node_is_wire()
throughout VTR. Every timerr_graph.node_type(node) == CHANX || rr_graph.node_type(node) == CHANY
was used has been replaced withrr_graph.node_is_wire(node)
. In order to do this, I followed a pattern similar to that in previous RRGraphView PRs.Motivation and Context
Removes reliance upon CHANX and CHANY types when determining if node is a wire.
How Has This Been Tested?
I have run the regression QoR testing found at
$ ../scripts/run_vtr_task.py regression_tests/vtr_reg_nightly_test3/vtr_reg_qor_chain
. Results from these QoR tests can be found below. The file containing all results can be found hereOnly rows that are different are shown.
Types of changes
Checklist: