Skip to content

Wrong definition of the type AsyncComponentFactory #10252

New issue
New issue
Open
#13230
#10253
Open
Wrong definition of the type AsyncComponentFactory#10252
#13230
#10253
Labels
good first issuehas PRtypescript
@Maorey

Description

@Maorey
Maorey
opened on Jul 10, 2019

Version

2.6.10

Reproduction link

https://github.com/vuejs/vue

Steps to reproduce

  1. compare the AsyncComponentFactory definition with the document

What is expected?

attribute 'component' should be a promise

What is actually happening?

AsyncComponentPromise

I'm looking forward to your solution to this issue

Activity

posva
added
good first issue
typescript
on Jul 10, 2019
posva

posva commented on Jul 10, 2019

@posva
posva
on Jul 10, 2019
Member

It seems the type should be Promise<Component | EsModuleComponent>

NataliaTepluhina
linked a pull request that will close this issue on Jul 10, 2019
posva
added
has PR
on Jul 10, 2019
NataliaTepluhina
added 2 commits that reference this issue on Jul 14, 2019

fix: add test for AsyncComponentFactory

3be9e28

fix: fixed a type for AsyncComponentFactory component

f75a39d
Maorey
closed this as completedon Jul 22, 2019
posva
reopened this on Jul 22, 2019
harshajayaweeraXHJ

harshajayaweeraXHJ commented on Aug 31, 2019

@harshajayaweeraXHJ
harshajayaweeraXHJ
on Aug 31, 2019

Is this issue still available

jvik

jvik commented on Oct 2, 2019

@jvik
jvik
on Oct 2, 2019

@harshajayaweeraXHJ The issue already has a PR

juzhiyuan

juzhiyuan commented on Aug 3, 2021

@juzhiyuan
juzhiyuan
on Aug 3, 2021

Any update here?

tulpauction001

tulpauction001 commented on Sep 14, 2021

@tulpauction001
tulpauction001
on Sep 14, 2021 · Hidden as off-topic
guptadeepak8

guptadeepak8 commented on Jan 16, 2022

@guptadeepak8
guptadeepak8
on Jan 16, 2022

is anyone working on this issue ?

adamcole123

adamcole123 commented on Jan 16, 2022

@adamcole123
adamcole123
on Jan 16, 2022

@guptadeepak8 This issue already has a PR but looks like it still needs to be merged.

16 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issuehas PRtypescript

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @posva@juzhiyuan@harshajayaweeraXHJ@ChairBorn@red3blue

      Issue actions
        Wrong definition of the type AsyncComponentFactory · Issue #10252 · vuejs/vue