You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Regarding link handling the DOM renderer is pretty straight forward - it re-renders a line with underlines applied/remove from the linkifier events. A quickfix is prolly possible by internally eval'ing the selection state.
A better long-term fix would involve changes on the linkifier, as the question here is, why it sends link events for selections in the first place. The mouse listeneners are quite scattered over the codebase currently, imho we would need a proper mouse listener service as a global orchestrator to fix this more reliably in the future.
Activity
jerch commentedon Sep 18, 2023
Regarding link handling the DOM renderer is pretty straight forward - it re-renders a line with underlines applied/remove from the linkifier events. A quickfix is prolly possible by internally eval'ing the selection state.
A better long-term fix would involve changes on the linkifier, as the question here is, why it sends link events for selections in the first place. The mouse listeneners are quite scattered over the codebase currently, imho we would need a proper mouse listener service as a global orchestrator to fix this more reliably in the future.
tisilent commentedon Sep 19, 2023
Fixed it, there is still an issue where the dashed line will not be visible. 🤪
tisilent commentedon May 13, 2024
Two types of underline can be displayed simultaneously.
But this method doesn't feel very good.
Need to process the curve...... 👻