Skip to content

DOM Renderer: display underline when selection link content #4811

@tisilent

Description

@tisilent
Contributor
20230918_222155.mp4

Activity

jerch

jerch commented on Sep 18, 2023

@jerch
Member

Regarding link handling the DOM renderer is pretty straight forward - it re-renders a line with underlines applied/remove from the linkifier events. A quickfix is prolly possible by internally eval'ing the selection state.

A better long-term fix would involve changes on the linkifier, as the question here is, why it sends link events for selections in the first place. The mouse listeneners are quite scattered over the codebase currently, imho we would need a proper mouse listener service as a global orchestrator to fix this more reliably in the future.

tisilent

tisilent commented on Sep 19, 2023

@tisilent
ContributorAuthor

Fixed it, there is still an issue where the dashed line will not be visible. 🤪

linked a pull request that will close this issue on May 13, 2024
tisilent

tisilent commented on May 13, 2024

@tisilent
ContributorAuthor

企业微信截图_17155832327359
Two types of underline can be displayed simultaneously.
But this method doesn't feel very good.
Need to process the curve...... 👻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @Tyriar@jerch@tisilent

      Issue actions

        DOM Renderer: display underline when selection link content · Issue #4811 · xtermjs/xterm.js