Description
Describe the bug
platforms:
- s32z2xxdc2@D/s32z270/rtu1
- s32z2xxdc2@B/s32z270/rtu1
- s32z2xxdc2@D/s32z270/rtu0
- s32z2xxdc2@B/s32z270/rtu0
git bisect found below commit introduce failure
git bisect sha: f715301
commit f7153012eff53b28dfa77b3ea2f76fb75d9fc812
Author: Fin Maaß <f.maass@vogl-electronic.com>
Date: Mon Apr 28 13:55:34 2025 +0200
dts: enum_macros: make sure that they are lowercase
DT_ENUM_HAS_VALUE_BY_IDX states, that the value
must be lowercase-and-underscores, this makes sure,
that they can match.
Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
drivers/comparator/comparator_nrf_comp.c | 6 +++---
drivers/comparator/comparator_nrf_lpcomp.c | 2 +-
scripts/dts/gen_defines.py | 3 +++
3 files changed, 7 insertions(+), 4 deletions(-)
Regression
- This is a regression.
Steps to reproduce
scripts/twister -p s32z2xxdc2@D/s32z270/rtu1 -T tests/drivers/pwm --build-only
Relevant log output
/home/jenkins/agent/workspace/zephyr_downstream_build_daily/zephyr/drivers/pwm/pwm_nxp_s32_emios.c
In file included from /home/jenkins/agent/workspace/zephyr_downstream_build_daily/zephyr/include/zephyr/sys/util_macro.h:34,
from /home/jenkins/agent/workspace/zephyr_downstream_build_daily/zephyr/include/zephyr/irq_multilevel.h:16,
from /home/jenkins/agent/workspace/zephyr_downstream_build_daily/zephyr/include/zephyr/devicetree.h:20,
from /home/jenkins/agent/workspace/zephyr_downstream_build_daily/zephyr/include/zephyr/device.h:12,
from /home/jenkins/agent/workspace/zephyr_downstream_build_daily/zephyr/drivers/pwm/pwm_nxp_s32_emios.c:7:
/home/jenkins/agent/workspace/zephyr_downstream_build_daily/zephyr/drivers/pwm/pwm_nxp_s32_emios.c:842:49: error: 'EMIOS_PWM_IP_MODE_SAIC_FLAG' undeclared here (not in a function); did you mean 'EMIOS_PWM_IP_MODE_DAOC_FLAG'?
842 | #define EMIOS_PWM_MODE(mode) DT_CAT3(EMIOS_PWM_IP_MODE_, mode, _FLAG)
| ^~~~~~~~~~~~~~~~~~
/home/jenkins/agent/workspace/zephyr_downstream_build_daily/zephyr/include/zephyr/sys/util_internal.h:72:26: note: in definition of macro '__DEBRACKET'
Impact
S32 PWM tests
Environment
OS: Ubuntu
Tool chain: Zephyr SDK
Version: nxp-v4.1.0-19362-g779c8d5e74b2
Activity
manuargue commentedon May 30, 2025
also affecting
mr_canhubk3
board[-]tests: drivers.pwm.loopback.pwm_loopback.capture_timeout: NXP S32 platform need update dts due to driver change[/-][+]tests: drivers.pwm.loopback.pwm_loopback.capture_timeout fail to build[/+]dleach02 commentedon Jun 5, 2025
@maass-hamburg Hake bisected this failure down to your commit. Could you also take a look at this?
manuargue commentedon Jun 5, 2025
NXP is working on a fix already
maass-hamburg commentedon Jun 5, 2025
@manuargue @dleach02 seems like I forgot to make the value lowercase in the uses of of DT_ENUM_HAS_VALUE() in
drivers/pwm/pwm_nxp_s32_emios.c
manuargue commentedon Jun 5, 2025
if it's a trivial change and you already know how to address it, feel free to open a pr. NXP have it assigned with low pio. Thanks
maass-hamburg commentedon Jun 5, 2025
@manuargue
hal: zephyrproject-rtos/hal_nxp#552
zephyr: #91125