Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neorg): Update version #1384

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Std-Enigma
Copy link
Contributor

📑 Description

Improve neorg community package

ℹ Additional Information

  • Use the latest stable version(Currently the version that this package use is v.8 but the latest major version of this plugin is v.9)
  • Download the proper treesitter packages to ensure a better note taking experience

Copy link

github-actions bot commented Mar 2, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review, the proper one will come later:
Pin the plugin to 9.0.
Also relevant breaking changes:
https://vhyrro.github.io/posts/neorg-9-0-0/

@Std-Enigma Std-Enigma changed the title Dev neorg refactor(neorg) Mar 2, 2025
@luxus
Copy link
Member

luxus commented Mar 2, 2025

after a quick copy paste

Failed to run `config` for neorg

.../lua/neorg/modules/core/integrations/nvim-cmp/module.lua:46: attempt to index field 'lsp' (a nil value)

# stacktrace:
  - /neorg/lua/neorg/modules/core/integrations/nvim-cmp/module.lua:46 _in_ **create_source**
  - /neorg/lua/neorg/modules/core/completion/module.lua:314 _in_ **load**
  - /neorg/lua/neorg/core/modules.lua:446 _in_ **load_module**
  - /neorg/lua/neorg/init.lua:100 _in_ **org_file_entered**
  - /neorg/lua/neorg/init.lua:45 _in_ **setup**

didn't have time to test further
ah i use blink instead of nvim-cmp nvim-neorg/neorg#1603

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR breaks 0.9 support. So we should either:

  • add both neovim 0.10 support and 0.9
    or
  • Wait until astro v5 is released.

@Uzaaft Uzaaft changed the title refactor(neorg) feat(neorg): Update version Mar 2, 2025
@Uzaaft
Copy link
Member

Uzaaft commented Mar 8, 2025

@Std-Enigma Any updates? U wanna wait until v5 or make the required changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants