Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a ToString() so I can see these easier in the debugger. #2934

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added a ToString() so I can see these easier in the debugger. #2934

wants to merge 2 commits into from

Conversation

zippy1981
Copy link
Contributor

@zippy1981 zippy1981 commented Jun 30, 2022 •
edited
Loading

Summary of changes

Added a ToString to ImmutableInstrumentationSettings

Reason for change

So I can see them all as a list in the visual studio debugger.

Implementation details

Just Tostring()

Test coverage

Added coverage to exiting tests

Other details

@zippy1981 zippy1981 requested a review from a team as a code owner June 30, 2022 22:55
pierotibou
pierotibou requested changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@pierotibou pierotibou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks a lot for the extra test.
Would you mind changing the use of the ToString to a DebuggerDisplay attribute and assert the right variables public please?
Obviously, I can also take it from here if need be. Thanks again for your contributions

@zippy1981 zippy1981 requested review from a team as code owners July 5, 2022 19:02
@zippy1981
Copy link
Contributor Author

What's this waiting on to be merged?

@zippy1981
Copy link
Contributor Author

@pierotibou should I rebase with latest?

@andrewlock andrewlock force-pushed the feature/immutable-integration-settings-tostring branch from ba47f54 to 1a298df Compare October 3, 2022 14:00
@andrewlock andrewlock force-pushed the feature/immutable-integration-settings-tostring branch from 1a298df to 175a1df Compare October 4, 2022 13:14
@andrewlock andrewlock mentioned this pull request Oct 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock

@lucaspimentel lucaspimentel

@pierotibou pierotibou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zippy1981 @lucaspimentel @andrewlock @pierotibou